From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Subject: Re: [PATCH v2] vfio: Support for no-IOMMU mode
Date: Thu, 14 Jan 2016 09:50:15 +0000
Message-ID: <C6ECDF3AB251BE4894318F4E45123697820BD5A8@IRSMSX109.ger.corp.intel.com>
References: <1450728967-9686-1-git-send-email-anatoly.burakov@intel.com>
 <1452688569-14695-1-git-send-email-anatoly.burakov@intel.com>
 <20160113084531.6bd4e3c6@xeon-e3>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "dev@dpdk.org" <dev@dpdk.org>
To: Stephen Hemminger <stephen@networkplumber.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id AEE49952
 for <dev@dpdk.org>; Thu, 14 Jan 2016 10:50:18 +0100 (CET)
In-Reply-To: <20160113084531.6bd4e3c6@xeon-e3>
Content-Language: en-US
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Stephen,

> > +/* IOMMU types we support */
> > +static const struct vfio_iommu_type iommu_types[] =3D {
> > +		/* x86 IOMMU, otherwise known as type 1 */
> > +		{ VFIO_TYPE1_IOMMU, "Type 1",
> &vfio_iommu_type1_dma_map},
> > +		/* IOMMU-less mode */
> > +		{ VFIO_NOIOMMU_IOMMU, "No-IOMMU",
> &vfio_iommu_noiommu_dma_map},
> > +};
> > +
>=20
> Nit.. Why full-tab indent here?

Readability mainly... at least it's more readable to me that way. I can cha=
nge that if necessary.

Thanks,
Anatoly