From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Subject: Re: [PATCH v2] vfio: Fix vfio disable INTx
Date: Tue, 28 Mar 2017 15:28:50 +0000
Message-ID: <C6ECDF3AB251BE4894318F4E451236978220A553@IRSMSX109.ger.corp.intel.com>
References: <1490742934-30608-1-git-send-email-nikhil.rao@intel.com>
 <1490745247-32001-1-git-send-email-nikhil.rao@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "dev@dpdk.org" <dev@dpdk.org>
To: "Rao, Nikhil" <nikhil.rao@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id DB89BCFBA
 for <dev@dpdk.org>; Tue, 28 Mar 2017 17:28:53 +0200 (CEST)
In-Reply-To: <1490745247-32001-1-git-send-email-nikhil.rao@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

> From: Rao, Nikhil
> Sent: Wednesday, March 29, 2017 12:54 AM
> To: Burakov, Anatoly <anatoly.burakov@intel.com>
> Cc: dev@dpdk.org
> Subject: [PATCH v2] vfio: Fix vfio disable INTx
>=20
> The flags member of irq_set should be ORed with
> VFIO_IRQ_SET_ACTION_MASK and not VFIO_IRQ_SET_ACTION_UNMASK.
> The bug was found by code inspection.
>=20
> Fixes: 5c782b3928b8 (\"vfio: interrupts\")
>=20
> Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>

Great find!

Acked-by: Anatoly  Burakov <anatoly.burakov@intel.com>