From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Burakov, Anatoly" Subject: Re: [PATCH dpdk 2/5] pci: Initialize common rte driver pointer Date: Mon, 24 Apr 2017 09:28:23 +0000 Message-ID: References: <20170420072402.38106-1-aik@ozlabs.ru> <20170420072402.38106-3-aik@ozlabs.ru> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "JPF@zurich.ibm.com" , Gowrishankar Muthukrishnan To: Alexey Kardashevskiy , "dev@dpdk.org" Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id A5C45298F for ; Mon, 24 Apr 2017 11:28:27 +0200 (CEST) In-Reply-To: <20170420072402.38106-3-aik@ozlabs.ru> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Alexey > Kardashevskiy > Sent: Thursday, April 20, 2017 8:24 AM > To: dev@dpdk.org > Cc: Alexey Kardashevskiy ; JPF@zurich.ibm.com; > Gowrishankar Muthukrishnan > Subject: [dpdk-dev] [PATCH dpdk 2/5] pci: Initialize common rte driver > pointer >=20 > The existing code initializes a PCI driver pointer but not the common one= . > As the result, ring_dma_zone_reserve() in drivers/net/bnx2x/bnx2x_rxtx.c > crashed as dev->device->driver=3D=3DNULL. >=20 > This adds missing initialization. >=20 > Signed-off-by: Alexey Kardashevskiy This and 3rd patch - could you please split them so that there are no unrel= ated patches in the patchset? I.e. a patchset for VFIO changes, a separate = patch for PCI, and a patch for bnx2x driver, and then just make a note in t= he annotation that they are interdependent. Thanks, Anatoly