From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [PATCH] to fix the bug for tboot on x86_32 brought by c/s 19914 and 19922 Date: Fri, 06 Nov 2009 16:20:10 +0000 Message-ID: References: <4AF408A1.9060600@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4AF408A1.9060600@intel.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Shane Wang , "xen-devel@lists.xensource.com" , "Cihula, Joseph" , "xudong.hao@intel.com" List-Id: xen-devel@lists.xenproject.org On 06/11/2009 11:29, "Shane Wang" wrote: > The changesets 19914 and 19922 remove the bitmap for boot allocator, which > causes first_valid_mfn is reduced and starts from the end of xen. On the other > hand, on x86_64, the xen heap is got considering e820 table, while on x86_32 > the xen heap is specified to be < xenheap_phys_end. This range overlaps tboot > range. > So, the tboot range is scrubbed by scrub_heap_pages() during start_xen() on > x86_32. Then the result is that for TXT support on x86_32, shutdown/reboot/Sx > doesn't work properly. (i.e. hang) So... The problem is that xenheap on x86_32 does not respect e820? I'll fix that if that's the issue. It will be a much smaller change, and to arch/x86/setup.c only. -- Keir > This patch is to fix that by reserving tboot range as "inuse" in xen heap on > x86_32. Then xen code will not touch the range.