From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Mohammed, Afzal" Subject: RE: [PATCH v5 07/14] ARM: OMAP2+: gpmc: time setting (register#) helper Date: Wed, 13 Jun 2012 06:15:38 +0000 Message-ID: References: <4FD7909B.4040304@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT Return-path: Received: from devils.ext.ti.com ([198.47.26.153]:42884 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751991Ab2FMGQA convert rfc822-to-8bit (ORCPT ); Wed, 13 Jun 2012 02:16:00 -0400 In-Reply-To: <4FD7909B.4040304@ti.com> Content-Language: en-US Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: "Hunter, Jon" Cc: "tony@atomide.com" , "paul@pwsan.com" , "linux-omap@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Hi Jon, On Wed, Jun 13, 2012 at 00:25:23, Hunter, Jon wrote: > When are the timings calculated? Why not just use the existing > gpmc_cs_set_timings()? > > I guess I am not convinced that we need to have multiple formats to pass > timings such as clock, period, etc. > > I think that it is sufficient to pass the timings as time (period) as is > currently done and have the driver convert to clocks based upon the gpmc > fclk rate. Please see http://www.mail-archive.com/linux-omap@vger.kernel.org/msg69041.html Regards Afzal From mboxrd@z Thu Jan 1 00:00:00 1970 From: afzal@ti.com (Mohammed, Afzal) Date: Wed, 13 Jun 2012 06:15:38 +0000 Subject: [PATCH v5 07/14] ARM: OMAP2+: gpmc: time setting (register#) helper In-Reply-To: <4FD7909B.4040304@ti.com> References: <4FD7909B.4040304@ti.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Jon, On Wed, Jun 13, 2012 at 00:25:23, Hunter, Jon wrote: > When are the timings calculated? Why not just use the existing > gpmc_cs_set_timings()? > > I guess I am not convinced that we need to have multiple formats to pass > timings such as clock, period, etc. > > I think that it is sufficient to pass the timings as time (period) as is > currently done and have the driver convert to clocks based upon the gpmc > fclk rate. Please see http://www.mail-archive.com/linux-omap at vger.kernel.org/msg69041.html Regards Afzal