From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Mohammed, Afzal" Subject: RE: [PATCH v6 10/10] ARM: OMAP2+: tusb6010: generic timing calculation Date: Fri, 14 Sep 2012 10:20:02 +0000 Message-ID: References: <20120824194630.GU11011@atomide.com> <20120906204354.GJ1303@atomide.com> <20120911184606.GN23092@atomide.com>, Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="_002_C8443D0743D26F4388EA172BF4E2A7A93E9E3624DBDE01entticom_" Return-path: Received: from bear.ext.ti.com ([192.94.94.41]:47369 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758497Ab2INKUL (ORCPT ); Fri, 14 Sep 2012 06:20:11 -0400 In-Reply-To: Content-Language: en-US Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Tony Lindgren Cc: "paul@pwsan.com" , "linux-omap@vger.kernel.org" , "Hunter, Jon" , "linux-arm-kernel@lists.infradead.org" --_002_C8443D0743D26F4388EA172BF4E2A7A93E9E3624DBDE01entticom_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable * Mohammed, Afzal: Wednesday, September 12, 2012 3:20 PM=0A= =0A= > But some of the tusb async values is less by one. I need=0A= > to get it right.=0A= =0A= Reason has been identified. It was due to rounding error,=0A= no changes are required in the expressions. Moving=0A= completely to picoseconds resolves the issue.=0A= =0A= Can you please try with the attached patch ?=0A= =0A= Once it is confirmed that issue is resolved, I will cleanup=0A= gpmc-nand.c too (which would also take care of picoseconds)=0A= =0A= Note: As this mail is sent via exchange, I am attaching the=0A= patch so that it reaches you in proper way.=0A= =0A= Regards=0A= Afzal= --_002_C8443D0743D26F4388EA172BF4E2A7A93E9E3624DBDE01entticom_ Content-Type: text/x-patch; name="0001-gpmc-rounding-error-fix.patch" Content-Description: 0001-gpmc-rounding-error-fix.patch Content-Disposition: attachment; filename="0001-gpmc-rounding-error-fix.patch"; size=14228; creation-date="Fri, 14 Sep 2012 10:15:43 GMT"; modification-date="Fri, 14 Sep 2012 10:15:43 GMT" Content-Transfer-Encoding: base64 RnJvbSAxMDFiM2Q0YzU1OGJhZTQyMGNiZWJhNjM0ZjRkZWVhZTI3YzNiOTA1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBZnphbCBNb2hhbW1lZCA8YWZ6YWxAdGkuY29tPgpEYXRlOiBX ZWQsIDEyIFNlcCAyMDEyIDE5OjMwOjI3ICswNTMwClN1YmplY3Q6IFtQQVRDSF0gZ3BtYzogcm91 bmRpbmcgZXJyb3IgZml4CgpTaWduZWQtb2ZmLWJ5OiBBZnphbCBNb2hhbW1lZCA8YWZ6YWxAdGku Y29tPgotLS0KIGFyY2gvYXJtL21hY2gtb21hcDIvZ3BtYy5jICAgICAgICAgICAgIHwgIDE1MCAr KysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLQogYXJjaC9hcm0vcGxhdC1vbWFwL2luY2x1 ZGUvcGxhdC9ncG1jLmggfCAgIDQwICsrKystLS0tCiAyIGZpbGVzIGNoYW5nZWQsIDkwIGluc2Vy dGlvbnMoKyksIDEwMCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9hcmNoL2FybS9tYWNoLW9t YXAyL2dwbWMuYyBiL2FyY2gvYXJtL21hY2gtb21hcDIvZ3BtYy5jCmluZGV4IGQ4ZTViMDguLmU5 ZDU3ZGIgMTAwNjQ0Ci0tLSBhL2FyY2gvYXJtL21hY2gtb21hcDIvZ3BtYy5jCisrKyBiL2FyY2gv YXJtL21hY2gtb21hcDIvZ3BtYy5jCkBAIC0yODksMTEgKzI4OSwxMSBAQCBzdGF0aWMgaW50IHNl dF9ncG1jX3RpbWluZ19yZWcoaW50IGNzLCBpbnQgcmVnLCBpbnQgc3RfYml0LCBpbnQgZW5kX2Jp dCwKIAlpZiAodGltZSA9PSAwKQogCQl0aWNrcyA9IDA7CiAJZWxzZQotCQl0aWNrcyA9IGdwbWNf bnNfdG9fdGlja3ModGltZSk7CisJCXRpY2tzID0gZ3BtY19wc190b190aWNrcyh0aW1lKTsKIAlu cl9iaXRzID0gZW5kX2JpdCAtIHN0X2JpdCArIDE7CiAJaWYgKHRpY2tzID49IDEgPDwgbnJfYml0 cykgewogI2lmZGVmIERFQlVHCi0JCXByaW50ayhLRVJOX0lORk8gIkdQTUMgQ1MlZDogJS0xMHMq ICUzZCBucywgJTNkIHRpY2tzID49ICVkXG4iLAorCQlwcl9pbmZvKCJHUE1DIENTJWQ6ICUtMTBz KiAlM2QgcHMsICUzZCB0aWNrcyA+PSAlZFxuIiwKIAkJCQljcywgbmFtZSwgdGltZSwgdGlja3Ms IDEgPDwgbnJfYml0cyk7CiAjZW5kaWYKIAkJcmV0dXJuIC0xOwpAQCAtMzAyLDEwICszMDIsOSBA QCBzdGF0aWMgaW50IHNldF9ncG1jX3RpbWluZ19yZWcoaW50IGNzLCBpbnQgcmVnLCBpbnQgc3Rf Yml0LCBpbnQgZW5kX2JpdCwKIAltYXNrID0gKDEgPDwgbnJfYml0cykgLSAxOwogCWwgPSBncG1j X2NzX3JlYWRfcmVnKGNzLCByZWcpOwogI2lmZGVmIERFQlVHCi0JcHJpbnRrKEtFUk5fSU5GTwot CQkiR1BNQyBDUyVkOiAlLTEwczogJTNkIHRpY2tzLCAlM2x1IG5zICh3YXMgJTNpIHRpY2tzKSAl M2QgbnNcbiIsCi0JICAgICAgIGNzLCBuYW1lLCB0aWNrcywgZ3BtY19nZXRfZmNsa19wZXJpb2Qo KSAqIHRpY2tzIC8gMTAwMCwKLQkJCShsID4+IHN0X2JpdCkgJiBtYXNrLCB0aW1lKTsKKwlwcl9p bmZvKCJHUE1DIENTJWQ6ICUtMTBzOiAlM2QgdGlja3MsICUzbHUgcHMgKHdhcyAlM2kgdGlja3Mp ICUzZCBwc1xuIiwKKwkJY3MsIG5hbWUsIHRpY2tzLCBncG1jX2dldF9mY2xrX3BlcmlvZCgpICog dGlja3MsCisJCShsID4+IHN0X2JpdCkgJiBtYXNrLCB0aW1lKTsKICNlbmRpZgogCWwgJj0gfiht YXNrIDw8IHN0X2JpdCk7CiAJbCB8PSB0aWNrcyA8PCBzdF9iaXQ7CkBAIC0zODUsOCArMzg0LDgg QEAgaW50IGdwbWNfY3Nfc2V0X3RpbWluZ3MoaW50IGNzLCBjb25zdCBzdHJ1Y3QgZ3BtY190aW1p bmdzICp0KQogCWwgPSBncG1jX2NzX3JlYWRfcmVnKGNzLCBHUE1DX0NTX0NPTkZJRzEpOwogCWlm IChsICYgKEdQTUNfQ09ORklHMV9SRUFEVFlQRV9TWU5DIHwgR1BNQ19DT05GSUcxX1dSSVRFVFlQ RV9TWU5DKSkgewogI2lmZGVmIERFQlVHCi0JCXByaW50ayhLRVJOX0lORk8gIkdQTUMgQ1MlZCBD TEsgcGVyaW9kIGlzICVsdSBucyAoZGl2ICVkKVxuIiwKLQkJCQljcywgKGRpdiAqIGdwbWNfZ2V0 X2ZjbGtfcGVyaW9kKCkpIC8gMTAwMCwgZGl2KTsKKwkJcHJfaW5mbygiR1BNQyBDUyVkIENMSyBw ZXJpb2QgaXMgJWx1IHBzIChkaXYgJWQpXG4iLAorCQkJCWNzLCBkaXYgKiBncG1jX2dldF9mY2xr X3BlcmlvZCgpLCBkaXYpOwogI2VuZGlmCiAJCWwgJj0gfjB4MDM7CiAJCWwgfD0gKGRpdiAtIDEp OwpAQCAtOTIyLDQ2ICs5MjEsNDIgQEAgc3RhdGljIGludCBncG1jX2NhbGNfc3luY19yZWFkX3Rp bWluZ3Moc3RydWN0IGdwbWNfdGltaW5ncyAqZ3BtY190LAogCQkgKiBpbmRpcmVjdGx5IG5lY2Vz c2l0YXRlcyByZXF1aXJlbWVudCBvZiB0X2F2ZHBfciAmIHRfYXZkcF93CiAJCSAqIGluc3RlYWQg b2YgaGF2aW5nIGEgc2luZ2xlIHRfYXZkcAogCQkgKi8KLQkJdGVtcCA9IG1heF90KHUzMiwgdGVt cCwJZ3BtY190LT5jbGtfYWN0aXZhdGlvbiAqIDEwMDAgKwotCQkJCQkJCWRldl90LT50X2F2ZGgp OwotCQl0ZW1wID0gbWF4X3QodTMyLAotCQkJKGdwbWNfdC0+YWR2X29uICsgZ3BtY190aWNrc190 b19ucygxKSkgKiAxMDAwLCB0ZW1wKTsKKwkJdGVtcCA9IG1heF90KHUzMiwgdGVtcCwJZ3BtY190 LT5jbGtfYWN0aXZhdGlvbiArIGRldl90LT50X2F2ZGgpOworCQl0ZW1wID0gbWF4X3QodTMyLCBn cG1jX3QtPmFkdl9vbiArIGdwbWNfdGlja3NfdG9fcHMoMSksIHRlbXApOwogCX0KLQlncG1jX3Qt PmFkdl9yZF9vZmYgPSBncG1jX3JvdW5kX3BzX3RvX3RpY2tzKHRlbXApIC8gMTAwMDsKKwlncG1j X3QtPmFkdl9yZF9vZmYgPSBncG1jX3JvdW5kX3BzX3RvX3RpY2tzKHRlbXApOwogCiAJLyogb2Vf b24gKi8KIAl0ZW1wID0gZGV2X3QtPnRfb2Vhc3U7IC8qIHJlbW92ZSB0aGlzID8gKi8KIAlpZiAo bXV4KSB7Ci0JCXRlbXAgPSBtYXhfdCh1MzIsIHRlbXAsCi0JCQlncG1jX3QtPmNsa19hY3RpdmF0 aW9uICogMTAwMCArIGRldl90LT50X2FjaCk7Ci0JCXRlbXAgPSBtYXhfdCh1MzIsIHRlbXAsIChn cG1jX3QtPmFkdl9yZF9vZmYgKwotCQkJCWdwbWNfdGlja3NfdG9fbnMoZGV2X3QtPmN5Y19hYXZk aF9vZSkpICogMTAwMCk7CisJCXRlbXAgPSBtYXhfdCh1MzIsIHRlbXAsCWdwbWNfdC0+Y2xrX2Fj dGl2YXRpb24gKyBkZXZfdC0+dF9hY2gpOworCQl0ZW1wID0gbWF4X3QodTMyLCB0ZW1wLCBncG1j X3QtPmFkdl9yZF9vZmYgKworCQkJCWdwbWNfdGlja3NfdG9fcHMoZGV2X3QtPmN5Y19hYXZkaF9v ZSkpOwogCX0KLQlncG1jX3QtPm9lX29uID0gZ3BtY19yb3VuZF9wc190b190aWNrcyh0ZW1wKSAv IDEwMDA7CisJZ3BtY190LT5vZV9vbiA9IGdwbWNfcm91bmRfcHNfdG9fdGlja3ModGVtcCk7CiAK IAkvKiBhY2Nlc3MgKi8KIAkvKiBhbnkgc2NvcGUgZm9yIGltcHJvdmVtZW50ID8sIGJ5IGNvbWJp bmluZyBvZV9vbiAmIGNsa19hY3RpdmF0aW9uLAogCSAqIG5lZWQgdG8gY2hlY2sgd2hldGhlciBh Y2Nlc3MgPSBjbGtfYWN0aXZhdGlvbiArIHJvdW5kIHRvIHN5bmMgY2xrID8KIAkgKi8KIAl0ZW1w ID0gbWF4X3QodTMyLCBkZXZfdC0+dF9pYWEsCWRldl90LT5jeWNfaWFhICogZ3BtY190LT5zeW5j X2Nsayk7Ci0JdGVtcCArPSBncG1jX3QtPmNsa19hY3RpdmF0aW9uICogMTAwMDsKKwl0ZW1wICs9 IGdwbWNfdC0+Y2xrX2FjdGl2YXRpb247CiAJaWYgKGRldl90LT5jeWNfb2UpCi0JCXRlbXAgPSBt YXhfdCh1MzIsIHRlbXAsIChncG1jX3QtPm9lX29uICsKLQkJCQlncG1jX3RpY2tzX3RvX25zKGRl dl90LT5jeWNfb2UpKSAqIDEwMDApOwotCWdwbWNfdC0+YWNjZXNzID0gZ3BtY19yb3VuZF9wc190 b190aWNrcyh0ZW1wKSAvIDEwMDA7CisJCXRlbXAgPSBtYXhfdCh1MzIsIHRlbXAsIGdwbWNfdC0+ b2Vfb24gKworCQkJCWdwbWNfdGlja3NfdG9fcHMoZGV2X3QtPmN5Y19vZSkpOworCWdwbWNfdC0+ YWNjZXNzID0gZ3BtY19yb3VuZF9wc190b190aWNrcyh0ZW1wKTsKIAotCWdwbWNfdC0+b2Vfb2Zm ID0gZ3BtY190LT5hY2Nlc3MgKyBncG1jX3RpY2tzX3RvX25zKDEpOworCWdwbWNfdC0+b2Vfb2Zm ID0gZ3BtY190LT5hY2Nlc3MgKyBncG1jX3RpY2tzX3RvX3BzKDEpOwogCWdwbWNfdC0+Y3NfcmRf b2ZmID0gZ3BtY190LT5vZV9vZmY7CiAKIAkvKiByZF9jeWNsZSAqLwogCXRlbXAgPSBtYXhfdCh1 MzIsIGRldl90LT50X2Nlel9yLCBkZXZfdC0+dF9vZXopOwogCXRlbXAgPSBncG1jX3JvdW5kX3Bz X3RvX3N5bmNfY2xrKHRlbXAsIGdwbWNfdC0+c3luY19jbGspICsKLQkJCQkJCQlncG1jX3QtPmFj Y2VzcyAqIDEwMDA7CisJCQkJCQkJZ3BtY190LT5hY2Nlc3M7CiAJLyogYmFydGVyIHRfY2VfcmR5 eiB3aXRoIHRfY2V6X3IgPyAqLwogCWlmIChkZXZfdC0+dF9jZV9yZHl6KQotCQl0ZW1wID0gbWF4 X3QodTMyLCB0ZW1wLAotCQkJCWdwbWNfdC0+Y3NfcmRfb2ZmICogMTAwMCArIGRldl90LT50X2Nl X3JkeXopOwotCWdwbWNfdC0+cmRfY3ljbGUgPSBncG1jX3JvdW5kX3BzX3RvX3RpY2tzKHRlbXAp IC8gMTAwMDsKKwkJdGVtcCA9IG1heF90KHUzMiwgdGVtcCwJZ3BtY190LT5jc19yZF9vZmYgKyBk ZXZfdC0+dF9jZV9yZHl6KTsKKwlncG1jX3QtPnJkX2N5Y2xlID0gZ3BtY19yb3VuZF9wc190b190 aWNrcyh0ZW1wKTsKIAogCXJldHVybiAwOwogfQpAQCAtOTc2LDI5ICs5NzEsMjggQEAgc3RhdGlj IGludCBncG1jX2NhbGNfc3luY193cml0ZV90aW1pbmdzKHN0cnVjdCBncG1jX3RpbWluZ3MgKmdw bWNfdCwKIAl0ZW1wID0gZGV2X3QtPnRfYXZkcF93OwogCWlmIChtdXgpIHsKIAkJdGVtcCA9IG1h eF90KHUzMiwgdGVtcCwKLQkJCWdwbWNfdC0+Y2xrX2FjdGl2YXRpb24gKiAxMDAwICsgZGV2X3Qt PnRfYXZkaCk7Ci0JCXRlbXAgPSBtYXhfdCh1MzIsCi0JCQkoZ3BtY190LT5hZHZfb24gKyBncG1j X3RpY2tzX3RvX25zKDEpKSAqIDEwMDAsIHRlbXApOworCQkJZ3BtY190LT5jbGtfYWN0aXZhdGlv biArIGRldl90LT50X2F2ZGgpOworCQl0ZW1wID0gbWF4X3QodTMyLCBncG1jX3QtPmFkdl9vbiAr IGdwbWNfdGlja3NfdG9fcHMoMSksIHRlbXApOwogCX0KLQlncG1jX3QtPmFkdl93cl9vZmYgPSBn cG1jX3JvdW5kX3BzX3RvX3RpY2tzKHRlbXApIC8gMTAwMDsKKwlncG1jX3QtPmFkdl93cl9vZmYg PSBncG1jX3JvdW5kX3BzX3RvX3RpY2tzKHRlbXApOwogCiAJLyogd3JfZGF0YV9tdXhfYnVzICov CiAJdGVtcCA9IG1heF90KHUzMiwgZGV2X3QtPnRfd2Vhc3UsCi0JCQlncG1jX3QtPmNsa19hY3Rp dmF0aW9uICogMTAwMCArIGRldl90LT50X3JkeW8pOworCQkJZ3BtY190LT5jbGtfYWN0aXZhdGlv biArIGRldl90LT50X3JkeW8pOwogCS8qIHNob3VsZG4ndCBtdXggYmUga2VwdCBhcyBhIHdob2xl IGZvciB3cl9kYXRhX211eF9idXMgPywKIAkgKiBhbmQgaW4gdGhhdCBjYXNlIHJlbWVtYmVyIHRv IGhhbmRsZSB3ZV9vbiBwcm9wZXJseQogCSAqLwogCWlmIChtdXgpIHsKIAkJdGVtcCA9IG1heF90 KHUzMiwgdGVtcCwKLQkJCWdwbWNfdC0+YWR2X3dyX29mZiAqIDEwMDAgKyBkZXZfdC0+dF9hYXZk aCk7Ci0JCXRlbXAgPSBtYXhfdCh1MzIsIHRlbXAsIChncG1jX3QtPmFkdl93cl9vZmYgKwotCQkJ CWdwbWNfdGlja3NfdG9fbnMoZGV2X3QtPmN5Y19hYXZkaF93ZSkpICogMTAwMCk7CisJCQlncG1j X3QtPmFkdl93cl9vZmYgKyBkZXZfdC0+dF9hYXZkaCk7CisJCXRlbXAgPSBtYXhfdCh1MzIsIHRl bXAsIGdwbWNfdC0+YWR2X3dyX29mZiArCisJCQkJZ3BtY190aWNrc190b19wcyhkZXZfdC0+Y3lj X2FhdmRoX3dlKSk7CiAJfQotCWdwbWNfdC0+d3JfZGF0YV9tdXhfYnVzID0gZ3BtY19yb3VuZF9w c190b190aWNrcyh0ZW1wKSAvIDEwMDA7CisJZ3BtY190LT53cl9kYXRhX211eF9idXMgPSBncG1j X3JvdW5kX3BzX3RvX3RpY2tzKHRlbXApOwogCiAJLyogd2Vfb24gKi8KIAlpZiAoZ3BtY19jYXBh YmlsaXR5ICYgR1BNQ19IQVNfV1JfREFUQV9NVVhfQlVTKQotCQlncG1jX3QtPndlX29uID0gZ3Bt Y19yb3VuZF9wc190b190aWNrcyhkZXZfdC0+dF93ZWFzdSkgLyAxMDAwOworCQlncG1jX3QtPndl X29uID0gZ3BtY19yb3VuZF9wc190b190aWNrcyhkZXZfdC0+dF93ZWFzdSk7CiAJZWxzZQogCQln cG1jX3QtPndlX29uID0gZ3BtY190LT53cl9kYXRhX211eF9idXM7CiAKQEAgLTEwMDcsMjQgKzEw MDEsMjQgQEAgc3RhdGljIGludCBncG1jX2NhbGNfc3luY193cml0ZV90aW1pbmdzKHN0cnVjdCBn cG1jX3RpbWluZ3MgKmdwbWNfdCwKIAlncG1jX3QtPndyX2FjY2VzcyA9IGdwbWNfdC0+YWNjZXNz OwogCiAJLyogd2Vfb2ZmICovCi0JdGVtcCA9IGdwbWNfdC0+d2Vfb24gKiAxMDAwICsgZGV2X3Qt PnRfd3BsOworCXRlbXAgPSBncG1jX3QtPndlX29uICsgZGV2X3QtPnRfd3BsOwogCXRlbXAgPSBt YXhfdCh1MzIsIHRlbXAsCi0JCQkoZ3BtY190LT53cl9hY2Nlc3MgKyBncG1jX3RpY2tzX3RvX25z KDEpKSAqIDEwMDApOworCQkJZ3BtY190LT53cl9hY2Nlc3MgKyBncG1jX3RpY2tzX3RvX3BzKDEp KTsKIAl0ZW1wID0gbWF4X3QodTMyLCB0ZW1wLAotCQkoZ3BtY190LT53ZV9vbiArIGdwbWNfdGlj a3NfdG9fbnMoZGV2X3QtPmN5Y193cGwpKSAqIDEwMDApOwotCWdwbWNfdC0+d2Vfb2ZmID0gZ3Bt Y19yb3VuZF9wc190b190aWNrcyh0ZW1wKSAvIDEwMDA7CisJCWdwbWNfdC0+d2Vfb24gKyBncG1j X3RpY2tzX3RvX3BzKGRldl90LT5jeWNfd3BsKSk7CisJZ3BtY190LT53ZV9vZmYgPSBncG1jX3Jv dW5kX3BzX3RvX3RpY2tzKHRlbXApOwogCi0JZ3BtY190LT5jc193cl9vZmYgPSBncG1jX3JvdW5k X3BzX3RvX3RpY2tzKGdwbWNfdC0+d2Vfb2ZmICogMTAwMCArCi0JCQkJCQkJZGV2X3QtPnRfd3Bo KSAvIDEwMDA7CisJZ3BtY190LT5jc193cl9vZmYgPSBncG1jX3JvdW5kX3BzX3RvX3RpY2tzKGdw bWNfdC0+d2Vfb2ZmICsKKwkJCQkJCQlkZXZfdC0+dF93cGgpOwogCiAJLyogd3JfY3ljbGUgKi8K IAl0ZW1wID0gZ3BtY19yb3VuZF9wc190b19zeW5jX2NsayhkZXZfdC0+dF9jZXpfdywgZ3BtY190 LT5zeW5jX2Nsayk7Ci0JdGVtcCArPSBncG1jX3QtPndyX2FjY2VzcyAqIDEwMDA7CisJdGVtcCAr PSBncG1jX3QtPndyX2FjY2VzczsKIAkvKiBiYXJ0ZXIgdF9jZV9yZHl6IHdpdGggdF9jZXpfdyA/ ICovCiAJaWYgKGRldl90LT50X2NlX3JkeXopCiAJCXRlbXAgPSBtYXhfdCh1MzIsIHRlbXAsCi0J CQkJIGdwbWNfdC0+Y3Nfd3Jfb2ZmICogMTAwMCArIGRldl90LT50X2NlX3JkeXopOwotCWdwbWNf dC0+d3JfY3ljbGUgPSBncG1jX3JvdW5kX3BzX3RvX3RpY2tzKHRlbXApIC8gMTAwMDsKKwkJCQkg Z3BtY190LT5jc193cl9vZmYgKyBkZXZfdC0+dF9jZV9yZHl6KTsKKwlncG1jX3QtPndyX2N5Y2xl ID0gZ3BtY19yb3VuZF9wc190b190aWNrcyh0ZW1wKTsKIAogCXJldHVybiAwOwogfQpAQCAtMTAz OCwzNSArMTAzMiwzMyBAQCBzdGF0aWMgaW50IGdwbWNfY2FsY19hc3luY19yZWFkX3RpbWluZ3Mo c3RydWN0IGdwbWNfdGltaW5ncyAqZ3BtY190LAogCS8qIGFkdl9yZF9vZmYgKi8KIAl0ZW1wID0g ZGV2X3QtPnRfYXZkcF9yOwogCWlmIChtdXgpCi0JCXRlbXAgPSBtYXhfdCh1MzIsCi0JCQkoZ3Bt Y190LT5hZHZfb24gKyBncG1jX3RpY2tzX3RvX25zKDEpKSAqIDEwMDAsIHRlbXApOwotCWdwbWNf dC0+YWR2X3JkX29mZiA9IGdwbWNfcm91bmRfcHNfdG9fdGlja3ModGVtcCkgLyAxMDAwOworCQl0 ZW1wID0gbWF4X3QodTMyLCBncG1jX3QtPmFkdl9vbiArIGdwbWNfdGlja3NfdG9fcHMoMSksIHRl bXApOworCWdwbWNfdC0+YWR2X3JkX29mZiA9IGdwbWNfcm91bmRfcHNfdG9fdGlja3ModGVtcCk7 CiAKIAkvKiBvZV9vbiAqLwogCXRlbXAgPSBkZXZfdC0+dF9vZWFzdTsKIAlpZiAobXV4KQogCQl0 ZW1wID0gbWF4X3QodTMyLCB0ZW1wLAotCQkJZ3BtY190LT5hZHZfcmRfb2ZmICogMTAwMCArIGRl dl90LT50X2FhdmRoKTsKLQlncG1jX3QtPm9lX29uID0gZ3BtY19yb3VuZF9wc190b190aWNrcyh0 ZW1wKSAvIDEwMDA7CisJCQlncG1jX3QtPmFkdl9yZF9vZmYgKyBkZXZfdC0+dF9hYXZkaCk7CisJ Z3BtY190LT5vZV9vbiA9IGdwbWNfcm91bmRfcHNfdG9fdGlja3ModGVtcCk7CiAKIAkvKiBhY2Nl c3MgKi8KIAl0ZW1wID0gbWF4X3QodTMyLCBkZXZfdC0+dF9pYWEsIC8qIHJlbW92ZSB0X2lhYSBp biBhc3luYyA/ICovCi0JCQkJZ3BtY190LT5vZV9vbiAqIDEwMDAgKyBkZXZfdC0+dF9vZSk7CisJ CQkJZ3BtY190LT5vZV9vbiArIGRldl90LT50X29lKTsKIAl0ZW1wID0gbWF4X3QodTMyLCB0ZW1w LAotCQkJCWdwbWNfdC0+Y3Nfb24gKiAxMDAwICsgZGV2X3QtPnRfY2UpOworCQkJCWdwbWNfdC0+ Y3Nfb24gKyBkZXZfdC0+dF9jZSk7CiAJdGVtcCA9IG1heF90KHUzMiwgdGVtcCwKLQkJCQlncG1j X3QtPmFkdl9vbiAqIDEwMDAgKyBkZXZfdC0+dF9hYSk7Ci0JZ3BtY190LT5hY2Nlc3MgPSBncG1j X3JvdW5kX3BzX3RvX3RpY2tzKHRlbXApIC8gMTAwMDsKKwkJCQlncG1jX3QtPmFkdl9vbiArIGRl dl90LT50X2FhKTsKKwlncG1jX3QtPmFjY2VzcyA9IGdwbWNfcm91bmRfcHNfdG9fdGlja3ModGVt cCk7CiAKLQlncG1jX3QtPm9lX29mZiA9IGdwbWNfdC0+YWNjZXNzICsgZ3BtY190aWNrc190b19u cygxKTsKKwlncG1jX3QtPm9lX29mZiA9IGdwbWNfdC0+YWNjZXNzICsgZ3BtY190aWNrc190b19w cygxKTsKIAlncG1jX3QtPmNzX3JkX29mZiA9IGdwbWNfdC0+b2Vfb2ZmOwogCiAJLyogcmRfY3lj bGUgKi8KIAl0ZW1wID0gbWF4X3QodTMyLCBkZXZfdC0+dF9yZF9jeWNsZSwKLQkJCWdwbWNfdC0+ Y3NfcmRfb2ZmICogMTAwMCArIGRldl90LT50X2Nlel9yKTsKLQl0ZW1wID0gbWF4X3QodTMyLCB0 ZW1wLAotCQkJZ3BtY190LT5vZV9vZmYgKiAxMDAwICsgZGV2X3QtPnRfb2V6KTsKLQlncG1jX3Qt PnJkX2N5Y2xlID0gZ3BtY19yb3VuZF9wc190b190aWNrcyh0ZW1wKSAvIDEwMDA7CisJCQlncG1j X3QtPmNzX3JkX29mZiArIGRldl90LT50X2Nlel9yKTsKKwl0ZW1wID0gbWF4X3QodTMyLCB0ZW1w LCBncG1jX3QtPm9lX29mZiArIGRldl90LT50X29leik7CisJZ3BtY190LT5yZF9jeWNsZSA9IGdw bWNfcm91bmRfcHNfdG9fdGlja3ModGVtcCk7CiAKIAlyZXR1cm4gMDsKIH0KQEAgLTEwODAsMzcg KzEwNzIsMzUgQEAgc3RhdGljIGludCBncG1jX2NhbGNfYXN5bmNfd3JpdGVfdGltaW5ncyhzdHJ1 Y3QgZ3BtY190aW1pbmdzICpncG1jX3QsCiAJLyogYWR2X3dyX29mZiAqLwogCXRlbXAgPSBkZXZf dC0+dF9hdmRwX3c7CiAJaWYgKG11eCkKLQkJdGVtcCA9IG1heF90KHUzMiwKLQkJCShncG1jX3Qt PmFkdl9vbiArIGdwbWNfdGlja3NfdG9fbnMoMSkpICogMTAwMCwgdGVtcCk7Ci0JZ3BtY190LT5h ZHZfd3Jfb2ZmID0gZ3BtY19yb3VuZF9wc190b190aWNrcyh0ZW1wKSAvIDEwMDA7CisJCXRlbXAg PSBtYXhfdCh1MzIsIGdwbWNfdC0+YWR2X29uICsgZ3BtY190aWNrc190b19wcygxKSwgdGVtcCk7 CisJZ3BtY190LT5hZHZfd3Jfb2ZmID0gZ3BtY19yb3VuZF9wc190b190aWNrcyh0ZW1wKTsKIAog CS8qIHdyX2RhdGFfbXV4X2J1cyAqLwogCXRlbXAgPSBkZXZfdC0+dF93ZWFzdTsKIAlpZiAobXV4 KSB7Ci0JCXRlbXAgPSBtYXhfdCh1MzIsIHRlbXAsCi0JCQlncG1jX3QtPmFkdl93cl9vZmYgKiAx MDAwICsgZGV2X3QtPnRfYWF2ZGgpOwotCQl0ZW1wID0gbWF4X3QodTMyLCB0ZW1wLCAoZ3BtY190 LT5hZHZfd3Jfb2ZmICsKLQkJCQlncG1jX3RpY2tzX3RvX25zKGRldl90LT5jeWNfYWF2ZGhfd2Up KSAqIDEwMDApOworCQl0ZW1wID0gbWF4X3QodTMyLCB0ZW1wLAlncG1jX3QtPmFkdl93cl9vZmYg KyBkZXZfdC0+dF9hYXZkaCk7CisJCXRlbXAgPSBtYXhfdCh1MzIsIHRlbXAsIGdwbWNfdC0+YWR2 X3dyX29mZiArCisJCQkJZ3BtY190aWNrc190b19wcyhkZXZfdC0+Y3ljX2FhdmRoX3dlKSk7CiAJ fQotCWdwbWNfdC0+d3JfZGF0YV9tdXhfYnVzID0gZ3BtY19yb3VuZF9wc190b190aWNrcyh0ZW1w KSAvIDEwMDA7CisJZ3BtY190LT53cl9kYXRhX211eF9idXMgPSBncG1jX3JvdW5kX3BzX3RvX3Rp Y2tzKHRlbXApOwogCiAJLyogd2Vfb24gKi8KIAlpZiAoZ3BtY19jYXBhYmlsaXR5ICYgR1BNQ19I QVNfV1JfREFUQV9NVVhfQlVTKQotCQlncG1jX3QtPndlX29uID0gZ3BtY19yb3VuZF9wc190b190 aWNrcyhkZXZfdC0+dF93ZWFzdSkgLyAxMDAwOworCQlncG1jX3QtPndlX29uID0gZ3BtY19yb3Vu ZF9wc190b190aWNrcyhkZXZfdC0+dF93ZWFzdSk7CiAJZWxzZQogCQlncG1jX3QtPndlX29uID0g Z3BtY190LT53cl9kYXRhX211eF9idXM7CiAKIAkvKiB3ZV9vZmYgKi8KLQl0ZW1wID0gZ3BtY190 LT53ZV9vbiAqIDEwMDAgKyBkZXZfdC0+dF93cGw7Ci0JZ3BtY190LT53ZV9vZmYgPSBncG1jX3Jv dW5kX3BzX3RvX3RpY2tzKHRlbXApIC8gMTAwMDsKKwl0ZW1wID0gZ3BtY190LT53ZV9vbiArIGRl dl90LT50X3dwbDsKKwlncG1jX3QtPndlX29mZiA9IGdwbWNfcm91bmRfcHNfdG9fdGlja3ModGVt cCk7CiAKLQlncG1jX3QtPmNzX3dyX29mZiA9IGdwbWNfcm91bmRfcHNfdG9fdGlja3MoKGdwbWNf dC0+d2Vfb2ZmICogMTAwMCArCi0JCQkJZGV2X3QtPnRfd3BoKSkgLyAxMDAwOworCWdwbWNfdC0+ Y3Nfd3Jfb2ZmID0gZ3BtY19yb3VuZF9wc190b190aWNrcyhncG1jX3QtPndlX29mZiArCisJCQkJ CQkJZGV2X3QtPnRfd3BoKTsKIAogCS8qIHdyX2N5Y2xlICovCiAJdGVtcCA9IG1heF90KHUzMiwg ZGV2X3QtPnRfd3JfY3ljbGUsCi0JCQkJZ3BtY190LT5jc193cl9vZmYgKiAxMDAwICsgZGV2X3Qt PnRfY2V6X3cpOwotCWdwbWNfdC0+d3JfY3ljbGUgPSBncG1jX3JvdW5kX3BzX3RvX3RpY2tzKHRl bXApIC8gMTAwMDsKKwkJCQlncG1jX3QtPmNzX3dyX29mZiArIGRldl90LT50X2Nlel93KTsKKwln cG1jX3QtPndyX2N5Y2xlID0gZ3BtY19yb3VuZF9wc190b190aWNrcyh0ZW1wKTsKIAogCXJldHVy biAwOwogfQpAQCAtMTEyNSwxMCArMTExNSwxMCBAQCBzdGF0aWMgaW50IGdwbWNfY2FsY19zeW5j X2NvbW1vbl90aW1pbmdzKHN0cnVjdCBncG1jX3RpbWluZ3MgKmdwbWNfdCwKIAogCWdwbWNfdC0+ cGFnZV9idXJzdF9hY2Nlc3MgPSBncG1jX3JvdW5kX3BzX3RvX3N5bmNfY2xrKAogCQkJCQlkZXZf dC0+dF9iYWNjLAotCQkJCQlncG1jX3QtPnN5bmNfY2xrKSAvIDEwMDA7CisJCQkJCWdwbWNfdC0+ c3luY19jbGspOwogCiAJdGVtcCA9IG1heF90KHUzMiwgZGV2X3QtPnRfY2VzLCBkZXZfdC0+dF9h dmRzKTsKLQlncG1jX3QtPmNsa19hY3RpdmF0aW9uID0gZ3BtY19yb3VuZF9wc190b190aWNrcyh0 ZW1wKSAvIDEwMDA7CisJZ3BtY190LT5jbGtfYWN0aXZhdGlvbiA9IGdwbWNfcm91bmRfcHNfdG9f dGlja3ModGVtcCk7CiAKIAlpZiAoZ3BtY19jYWxjX2RpdmlkZXIoZ3BtY190LT5zeW5jX2Nsaykg IT0gMSkKIAkJcmV0dXJuIDA7CkBAIC0xMTUxLDE0ICsxMTQxLDE0IEBAIHN0YXRpYyBpbnQgZ3Bt Y19jYWxjX2NvbW1vbl90aW1pbmdzKHN0cnVjdCBncG1jX3RpbWluZ3MgKmdwbWNfdCwKIAl1MzIg dGVtcDsKIAogCS8qIGNzX29uICovCi0JZ3BtY190LT5jc19vbiA9IGdwbWNfcm91bmRfbnNfdG9f dGlja3MoZGV2X3QtPnRfY2Vhc3UgLyAxMDAwKTsKKwlncG1jX3QtPmNzX29uID0gZ3BtY19yb3Vu ZF9wc190b190aWNrcyhkZXZfdC0+dF9jZWFzdSk7CiAKIAkvKiBhZHZfb24gKi8KIAl0ZW1wID0g ZGV2X3QtPnRfYXZkYXN1OwogCWlmIChkZXZfdC0+dF9jZV9hdmQpCiAJCXRlbXAgPSBtYXhfdCh1 MzIsIHRlbXAsCi0JCQkJZ3BtY190LT5jc19vbiAqIDEwMDAgKyBkZXZfdC0+dF9jZV9hdmQpOwot CWdwbWNfdC0+YWR2X29uID0gZ3BtY19yb3VuZF9uc190b190aWNrcyh0ZW1wIC8gMTAwMCk7CisJ CQkJZ3BtY190LT5jc19vbiArIGRldl90LT50X2NlX2F2ZCk7CisJZ3BtY190LT5hZHZfb24gPSBn cG1jX3JvdW5kX3BzX3RvX3RpY2tzKHRlbXApOwogCiAJaWYgKGRldl90LT5zeW5jX3dyaXRlIHx8 IGRldl90LT5zeW5jX3JlYWQpCiAJCWdwbWNfY2FsY19zeW5jX2NvbW1vbl90aW1pbmdzKGdwbWNf dCwgZGV2X3QpOwpkaWZmIC0tZ2l0IGEvYXJjaC9hcm0vcGxhdC1vbWFwL2luY2x1ZGUvcGxhdC9n cG1jLmggYi9hcmNoL2FybS9wbGF0LW9tYXAvaW5jbHVkZS9wbGF0L2dwbWMuaAppbmRleCBlNTlh OTMyLi5mMWQxZDJlIDEwMDY0NAotLS0gYS9hcmNoL2FybS9wbGF0LW9tYXAvaW5jbHVkZS9wbGF0 L2dwbWMuaAorKysgYi9hcmNoL2FybS9wbGF0LW9tYXAvaW5jbHVkZS9wbGF0L2dwbWMuaApAQCAt MTE2LDM4ICsxMTYsMzggQEAgc3RydWN0IGdwbWNfdGltaW5ncyB7CiAJdTMyIHN5bmNfY2xrOwog CiAJLyogQ2hpcC1zZWxlY3Qgc2lnbmFsIHRpbWluZ3MgY29ycmVzcG9uZGluZyB0byBHUE1DX0NT X0NPTkZJRzIgKi8KLQl1MTYgY3Nfb247CQkvKiBBc3NlcnRpb24gdGltZSAqLwotCXUxNiBjc19y ZF9vZmY7CQkvKiBSZWFkIGRlYXNzZXJ0aW9uIHRpbWUgKi8KLQl1MTYgY3Nfd3Jfb2ZmOwkJLyog V3JpdGUgZGVhc3NlcnRpb24gdGltZSAqLworCXUzMiBjc19vbjsJCS8qIEFzc2VydGlvbiB0aW1l ICovCisJdTMyIGNzX3JkX29mZjsJCS8qIFJlYWQgZGVhc3NlcnRpb24gdGltZSAqLworCXUzMiBj c193cl9vZmY7CQkvKiBXcml0ZSBkZWFzc2VydGlvbiB0aW1lICovCiAKIAkvKiBBRFYgc2lnbmFs IHRpbWluZ3MgY29ycmVzcG9uZGluZyB0byBHUE1DX0NPTkZJRzMgKi8KLQl1MTYgYWR2X29uOwkJ LyogQXNzZXJ0aW9uIHRpbWUgKi8KLQl1MTYgYWR2X3JkX29mZjsJCS8qIFJlYWQgZGVhc3NlcnRp b24gdGltZSAqLwotCXUxNiBhZHZfd3Jfb2ZmOwkJLyogV3JpdGUgZGVhc3NlcnRpb24gdGltZSAq LworCXUzMiBhZHZfb247CQkvKiBBc3NlcnRpb24gdGltZSAqLworCXUzMiBhZHZfcmRfb2ZmOwkJ LyogUmVhZCBkZWFzc2VydGlvbiB0aW1lICovCisJdTMyIGFkdl93cl9vZmY7CQkvKiBXcml0ZSBk ZWFzc2VydGlvbiB0aW1lICovCiAKIAkvKiBXRSBzaWduYWxzIHRpbWluZ3MgY29ycmVzcG9uZGlu ZyB0byBHUE1DX0NPTkZJRzQgKi8KLQl1MTYgd2Vfb247CQkvKiBXRSBhc3NlcnRpb24gdGltZSAq LwotCXUxNiB3ZV9vZmY7CQkvKiBXRSBkZWFzc2VydGlvbiB0aW1lICovCisJdTMyIHdlX29uOwkJ LyogV0UgYXNzZXJ0aW9uIHRpbWUgKi8KKwl1MzIgd2Vfb2ZmOwkJLyogV0UgZGVhc3NlcnRpb24g dGltZSAqLwogCiAJLyogT0Ugc2lnbmFscyB0aW1pbmdzIGNvcnJlc3BvbmRpbmcgdG8gR1BNQ19D T05GSUc0ICovCi0JdTE2IG9lX29uOwkJLyogT0UgYXNzZXJ0aW9uIHRpbWUgKi8KLQl1MTYgb2Vf b2ZmOwkJLyogT0UgZGVhc3NlcnRpb24gdGltZSAqLworCXUzMiBvZV9vbjsJCS8qIE9FIGFzc2Vy dGlvbiB0aW1lICovCisJdTMyIG9lX29mZjsJCS8qIE9FIGRlYXNzZXJ0aW9uIHRpbWUgKi8KIAog CS8qIEFjY2VzcyB0aW1lIGFuZCBjeWNsZSB0aW1lIHRpbWluZ3MgY29ycmVzcG9uZGluZyB0byBH UE1DX0NPTkZJRzUgKi8KLQl1MTYgcGFnZV9idXJzdF9hY2Nlc3M7CS8qIE11bHRpcGxlIGFjY2Vz cyB3b3JkIGRlbGF5ICovCi0JdTE2IGFjY2VzczsJCS8qIFN0YXJ0LWN5Y2xlIHRvIGZpcnN0IGRh dGEgdmFsaWQgZGVsYXkgKi8KLQl1MTYgcmRfY3ljbGU7CQkvKiBUb3RhbCByZWFkIGN5Y2xlIHRp bWUgKi8KLQl1MTYgd3JfY3ljbGU7CQkvKiBUb3RhbCB3cml0ZSBjeWNsZSB0aW1lICovCisJdTMy IHBhZ2VfYnVyc3RfYWNjZXNzOwkvKiBNdWx0aXBsZSBhY2Nlc3Mgd29yZCBkZWxheSAqLworCXUz MiBhY2Nlc3M7CQkvKiBTdGFydC1jeWNsZSB0byBmaXJzdCBkYXRhIHZhbGlkIGRlbGF5ICovCisJ dTMyIHJkX2N5Y2xlOwkJLyogVG90YWwgcmVhZCBjeWNsZSB0aW1lICovCisJdTMyIHdyX2N5Y2xl OwkJLyogVG90YWwgd3JpdGUgY3ljbGUgdGltZSAqLwogCi0JdTE2IGJ1c190dXJuYXJvdW5kOwot CXUxNiBjeWNsZTJjeWNsZV9kZWxheTsKKwl1MzIgYnVzX3R1cm5hcm91bmQ7CisJdTMyIGN5Y2xl MmN5Y2xlX2RlbGF5OwogCi0JdTE2IHdhaXRfbW9uaXRvcmluZzsKLQl1MTYgY2xrX2FjdGl2YXRp b247CisJdTMyIHdhaXRfbW9uaXRvcmluZzsKKwl1MzIgY2xrX2FjdGl2YXRpb247CiAKIAkvKiBU aGUgZm9sbG93aW5nIGFyZSBvbmx5IG9uIE9NQVAzNDMwICovCi0JdTE2IHdyX2FjY2VzczsJCS8q IFdSQUNDRVNTVElNRSAqLwotCXUxNiB3cl9kYXRhX211eF9idXM7CS8qIFdSREFUQU9OQURNVVhC VVMgKi8KKwl1MzIgd3JfYWNjZXNzOwkJLyogV1JBQ0NFU1NUSU1FICovCisJdTMyIHdyX2RhdGFf bXV4X2J1czsJLyogV1JEQVRBT05BRE1VWEJVUyAqLwogCiAJc3RydWN0IGdwbWNfYm9vbF90aW1p bmdzIGJvb2xfdGltaW5nczsKIH07Ci0tIAoxLjcuMC40Cgo= --_002_C8443D0743D26F4388EA172BF4E2A7A93E9E3624DBDE01entticom_-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: afzal@ti.com (Mohammed, Afzal) Date: Fri, 14 Sep 2012 10:20:02 +0000 Subject: [PATCH v6 10/10] ARM: OMAP2+: tusb6010: generic timing calculation In-Reply-To: References: <20120824194630.GU11011@atomide.com> <20120906204354.GJ1303@atomide.com> <20120911184606.GN23092@atomide.com>, Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org * Mohammed, Afzal: Wednesday, September 12, 2012 3:20 PM > But some of the tusb async values is less by one. I need > to get it right. Reason has been identified. It was due to rounding error, no changes are required in the expressions. Moving completely to picoseconds resolves the issue. Can you please try with the attached patch ? Once it is confirmed that issue is resolved, I will cleanup gpmc-nand.c too (which would also take care of picoseconds) Note: As this mail is sent via exchange, I am attaching the patch so that it reaches you in proper way. Regards Afzal -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-gpmc-rounding-error-fix.patch Type: text/x-patch Size: 14228 bytes Desc: 0001-gpmc-rounding-error-fix.patch URL: