From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161203Ab2CORzS (ORCPT ); Thu, 15 Mar 2012 13:55:18 -0400 Received: from g1t0029.austin.hp.com ([15.216.28.36]:9546 "EHLO g1t0029.austin.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161079Ab2CORzO (ORCPT ); Thu, 15 Mar 2012 13:55:14 -0400 From: "Nanjappa, Sathisha (MCXS, Cupertino)" To: James Bottomley CC: "linux-scsi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Chris Dunlop , "Nandigama, Nagalakshmi" Subject: RE: [PATCH] mpt2sas: Corrected the constant in comparison to a hexadecimal. Thread-Topic: [PATCH] mpt2sas: Corrected the constant in comparison to a hexadecimal. Thread-Index: AQHNAb0kYPKk1kFKbUOL9EWnl0kcTpZqbNNggACizACAAJQhAA== Date: Thu, 15 Mar 2012 17:54:56 +0000 Message-ID: References: <1331665168-22561-1-git-send-email-sathisha.nanjappa@hp.com> <1331665168-22561-2-git-send-email-sathisha.nanjappa@hp.com> <1331714014.8688.3.camel@dabdike> <1331801806.2941.3.camel@dabdike> In-Reply-To: <1331801806.2941.3.camel@dabdike> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [16.216.12.11] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id q2FHtKNK005599 > From: linux-kernel-owner@vger.kernel.org [mailto:linux-kernel- > owner@vger.kernel.org] On Behalf Of James Bottomley > Sent: Thursday, March 15, 2012 1:57 AM > > On Wed, 2012-03-14 at 23:36 +0000, Nanjappa, Sathisha (MCXS, Cupertino) > wrote: > > > > > > On Tue, 2012-03-13 at 11:59 -0700, Sathisha Nanjappa wrote: > > > > Bugzilla 42142 - mpt2sas: Number specified in wrong base > > > > https://bugzilla.kernel.org/show_bug.cgi?id=42142 > > > > > > From: James Bottomley > > > Sent: Wednesday, March 14, 2012 1:34 AM > > > Do you have a better description ... like what is the user > > > visible effect of correcting the constant? > > > > > > > Does this look better: > > > > "This fix ensures that the IOP_LOGINFO_CODE_TASK_TERMINATED > > messages do not clutter the sas_log_info messages." > > Much better, thanks. The whole point of a commit message is to explain > what you're doing and why you're doing it. Just translating C to > english isn't useful because everyone who looks a kernel patches can > read C. > Thanks for clarifying. I'll keep that in mind during my future submittal requests. FYI, I've received ack's from: Acked-by: "Nandigama, Nagalakshmi" Acked-by: "Chris Dunlop" -Satish. {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Nanjappa, Sathisha (MCXS, Cupertino)" Subject: RE: [PATCH] mpt2sas: Corrected the constant in comparison to a hexadecimal. Date: Thu, 15 Mar 2012 17:54:56 +0000 Message-ID: References: <1331665168-22561-1-git-send-email-sathisha.nanjappa@hp.com> <1331665168-22561-2-git-send-email-sathisha.nanjappa@hp.com> <1331714014.8688.3.camel@dabdike> <1331801806.2941.3.camel@dabdike> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1331801806.2941.3.camel@dabdike> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: James Bottomley Cc: "linux-scsi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Chris Dunlop , "Nandigama, Nagalakshmi" List-Id: linux-scsi@vger.kernel.org PiBGcm9tOiBsaW51eC1rZXJuZWwtb3duZXJAdmdlci5rZXJuZWwub3JnIFttYWlsdG86bGludXgt a2VybmVsLQ0KPiBvd25lckB2Z2VyLmtlcm5lbC5vcmddIE9uIEJlaGFsZiBPZiBKYW1lcyBCb3R0 b21sZXkNCj4gU2VudDogVGh1cnNkYXksIE1hcmNoIDE1LCAyMDEyIDE6NTcgQU0NCj4gDQo+IE9u IFdlZCwgMjAxMi0wMy0xNCBhdCAyMzozNiArMDAwMCwgTmFuamFwcGEsIFNhdGhpc2hhIChNQ1hT LCBDdXBlcnRpbm8pDQo+IHdyb3RlOg0KPiA+ID4NCj4gPiA+IE9uIFR1ZSwgMjAxMi0wMy0xMyBh dCAxMTo1OSAtMDcwMCwgU2F0aGlzaGEgTmFuamFwcGEgd3JvdGU6DQo+ID4gPiA+IEJ1Z3ppbGxh IDQyMTQyIC0gbXB0MnNhczogTnVtYmVyIHNwZWNpZmllZCBpbiB3cm9uZyBiYXNlDQo+ID4gPiA+ ICAgICBodHRwczovL2J1Z3ppbGxhLmtlcm5lbC5vcmcvc2hvd19idWcuY2dpP2lkPTQyMTQyDQo+ ID4gPg0KPiA+ID4gRnJvbTogSmFtZXMgQm90dG9tbGV5DQo+ID4gPiBTZW50OiBXZWRuZXNkYXks IE1hcmNoIDE0LCAyMDEyIDE6MzQgQU0NCj4gPiA+IERvIHlvdSBoYXZlIGEgYmV0dGVyIGRlc2Ny aXB0aW9uIC4uLiBsaWtlIHdoYXQgaXMgdGhlIHVzZXINCj4gPiA+IHZpc2libGUgZWZmZWN0IG9m IGNvcnJlY3RpbmcgdGhlIGNvbnN0YW50Pw0KPiA+ID4NCj4gPg0KPiA+IERvZXMgdGhpcyBsb29r IGJldHRlcjoNCj4gPg0KPiA+ICJUaGlzIGZpeCBlbnN1cmVzIHRoYXQgdGhlIElPUF9MT0dJTkZP X0NPREVfVEFTS19URVJNSU5BVEVEDQo+ID4gbWVzc2FnZXMgZG8gbm90IGNsdXR0ZXIgdGhlIHNh c19sb2dfaW5mbyBtZXNzYWdlcy4iDQo+IA0KPiBNdWNoIGJldHRlciwgdGhhbmtzLiAgVGhlIHdo b2xlIHBvaW50IG9mIGEgY29tbWl0IG1lc3NhZ2UgaXMgdG8gZXhwbGFpbg0KPiB3aGF0IHlvdSdy ZSBkb2luZyBhbmQgd2h5IHlvdSdyZSBkb2luZyBpdC4gIEp1c3QgdHJhbnNsYXRpbmcgQyB0bw0K PiBlbmdsaXNoIGlzbid0IHVzZWZ1bCBiZWNhdXNlIGV2ZXJ5b25lIHdobyBsb29rcyBhIGtlcm5l bCBwYXRjaGVzIGNhbg0KPiByZWFkIEMuDQo+IA0KDQpUaGFua3MgZm9yIGNsYXJpZnlpbmcuIEkn bGwga2VlcCB0aGF0IGluIG1pbmQgZHVyaW5nIG15IGZ1dHVyZSBzdWJtaXR0YWwgcmVxdWVzdHMu DQoNCkZZSSwgSSd2ZSByZWNlaXZlZCBhY2sncyBmcm9tOg0KDQpBY2tlZC1ieTogIk5hbmRpZ2Ft YSwgTmFnYWxha3NobWkiIDxOYWdhbGFrc2htaS5OYW5kaWdhbWFAbHNpLmNvbT4NCkFja2VkLWJ5 OiAiQ2hyaXMgRHVubG9wIiA8Y2hyaXNAb250aGUubmV0LmF1PiANCg0KLVNhdGlzaC4NCg0K