From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir@xen.org>
Subject: Re: Xen 4.1 rc1 test report
Date: Wed, 26 Jan 2011 07:24:33 +0000
Message-ID: <C9657CB1.12752%keir@xen.org>
References: <F26D193E20BBDC42A43B611D1BDEDE712556378A03@shsmsx502.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain;
	charset="ISO-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <F26D193E20BBDC42A43B611D1BDEDE712556378A03@shsmsx502.ccr.corp.intel.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: "Wei, Gang" <gang.wei@intel.com>, "Zheng, Shaohui" <shaohui.zheng@intel.com>, "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On 26/01/2011 06:31, "Wei, Gang" <gang.wei@intel.com> wrote:

> Wei, Gang wrote on=A02011-01-26:
>> Just found sometime while doing domain_destroy the current->domain is
>> IDLE domain, so the if ( !IS_PRIV_FOR(current->domain, d) ) hit and
>> skip the pirq forcible unbinding. How could it happen?
>=20
> Look like it is caused by call_rcu(&d->rcu, complete_domain_destroy) in t=
he
> end of domain_destroy fn. We may need to move the check for
> IS_PRIV_FOR(current->domain, d) out and check it earlier in the call path=
 if
> necessary.

Those core map/unmap functions shouldn't be doing the priv checks
themselves. I'll sort out a patch for you to try.

 -- Keir

> Jimmy
>=20
>=20