From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [PATCH] x86: suppress HPET broadcast initialization in the presence of ARAT Date: Sat, 12 Feb 2011 07:35:22 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "Wei, Gang" , Jan Beulich , "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On 12/02/2011 07:15, "Wei, Gang" wrote: > Jan Beulich wrote on=A02011-02-10: >> This follows Linux commit 39fe05e58c5e448601ce46e6b03900d5bf31c4b0, >> noticing that all this setup is pointless when ARAT support is there, >> and knowing that on SLED11's native kernel it has actually caused S3 res= ume >> issues. >>=20 >=20 > Although this patch was already checked in, I still have to say it is not > necessary for Xen. Because hpet_broadcast_init() fn is only called if > (xen_cpuidle && !boot_cpu_has(X86_FEATURE_ARAT)) in disable_pit_irq(). Of > course I agree to keep it as a never used double check. Hmm I didn't spot that. Actually it is part of a more complex series of checks in the caller, so I wonder whether repeating just that one check in the function itself really makes much sense. I'm somewhat inclibned to revert it. -- Keir > Jimmy >=20 >=20 >=20 > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel