From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir.xen@gmail.com>
Subject: Re: [PATCH] x86: don't write_tsc() non-zero values on
	CPUs updating only the lower 32 bits
Date: Fri, 15 Apr 2011 08:37:23 +0100
Message-ID: <C9CDB443.1661B%keir.xen@gmail.com>
References: <4DA80B1A020000780003C875@vpn.id2.novell.com>
Mime-Version: 1.0
Content-Type: text/plain;
	charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <4DA80B1A020000780003C875@vpn.id2.novell.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Jan Beulich <JBeulich@novell.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>, "winston.l.wang" <winston.l.wang@intel.com>
List-Id: xen-devel@lists.xenproject.org

On 15/04/2011 08:08, "Jan Beulich" <JBeulich@novell.com> wrote:

>> But the write is actually tsc + 4*(s32)(tmp-tsc), and tmp has 1U<<32 ORed
>> into it (because it was read after your second write to the TSC. Perhaps we
>> should just write back the full original tsc and call that good enough?
> 
> Again, note the (s32) cast.

Oh yes. Still the 4x is weird, and on this path (!TSC_RELIABLE, TSC is fully
writable) we will sync all AP TSCs as they come up anyway. So writing back
the original TSC value is good enough, as far as this matters at all (which
it probably doesn't).

 -- Keir