From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir@xen.org>
Subject: Re: [PATCH] X86: Fix a little mca bug
Date: Fri, 20 May 2011 09:10:18 +0100
Message-ID: <C9FBE07A.2D7D6%keir@xen.org>
References: <BC00F5384FCFC9499AF06F92E8B78A9E2083B2EDEA@shsmsx502.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain;
	charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <BC00F5384FCFC9499AF06F92E8B78A9E2083B2EDEA@shsmsx502.ccr.corp.intel.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: "Liu, Jinsong" <jinsong.liu@intel.com>, "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Cc: "Jiang, Yunhong" <yunhong.jiang@intel.com>, "Dong,
	Eddie" <eddie.dong@intel.com>, "Li, Xin" <xin.li@intel.com>
List-Id: xen-devel@lists.xenproject.org

On 19/05/2011 13:03, "Liu, Jinsong" <jinsong.liu@intel.com> wrote:

> X86: Fix a little mca bug
> 
> At x86_mcinfo_dump(), a little bug at printk information, illusively
> indicate an CMCI/POLLED error to a MCE error, this will make debug confusing.

Is it correct to have entirely removed the final else clause?

 -- Keir

> Signed-off-by: Liu, Jinsong <jinsong.liu@intel.com>
> 
> diff -r 2fe45768d2c1 xen/arch/x86/cpu/mcheck/mce.c
> --- a/xen/arch/x86/cpu/mcheck/mce.c Tue May 10 13:58:21 2011 +0800
> +++ b/xen/arch/x86/cpu/mcheck/mce.c Thu May 19 15:10:07 2011 +0800
> @@ -944,10 +944,11 @@ void x86_mcinfo_dump(struct mc_info *mi)
>          printk(XENLOG_WARNING
>                 "CPU%d: Machine Check Exception: %16"PRIx64"\n",
>                 mc_global->mc_coreid, mc_global->mc_gstatus);
> -    } else {
> -        printk(XENLOG_WARNING "MCE: The hardware reports a non "
> -               "fatal, correctable incident occurred on "
> -               "CPU %d.\n",
> +    } else if (mc_global->mc_flags & MC_FLAG_CMCI) {
> +        printk(XENLOG_WARNING "CMCI occurred on CPU %d.\n",
> +               mc_global->mc_coreid);
> +    } else if (mc_global->mc_flags & MC_FLAG_POLLED) {
> +        printk(XENLOG_WARNING "POLLED occurred on CPU %d.\n",
>                 mc_global->mc_coreid);
>      }
>