From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir@xen.org>
Subject: Re: [PATCH 03 of 45] gcc-4.6 compile fix:
	tools/xenstore/xenstored_core.c
Date: Fri, 20 May 2011 09:41:34 +0100
Message-ID: <C9FBE7CE.2D7EC%keir@xen.org>
References: <1305880225.20576.2.camel@zakaz.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain;
	charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <1305880225.20576.2.camel@zakaz.uk.xensource.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Olaf Hering <olaf@aepfle.de>, "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On 20/05/2011 09:30, "Ian Campbell" <Ian.Campbell@citrix.com> wrote:

>> I applied the first couple of these patches, but... We don't set
>> -Werror=unused-but-set-variable, so we don't actually need these fixes, do
>> we? Unless they are cleanups or fixes in some other way?
> 
> gcc 4.6 adds it to the default set of Werrors.

I'll take a patch from someone to remove it from the default set, please.
Until plenty of people are using gcc 4.6, it'll only get broken again and
again anyway, even if we applied all the current fixes.

I've applied all the patches that I considered nice cleanups, I'd like to
drop the rest.

 -- Keir