All of lore.kernel.org
 help / color / mirror / Atom feed
From: Frank Hunleth <fhunleth@troodon-software.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/1] package/php_amqp: fix build with php 7.3.0
Date: Thu, 3 Jan 2019 23:55:26 -0500	[thread overview]
Message-ID: <CA+-urNTjvCmbPx=-TqfRwSqCVjWYQA3=2Y1tpG6uVAesnsY_SQ@mail.gmail.com> (raw)
In-Reply-To: <20181231173152.01c9897f@windsurf>

On Mon, Dec 31, 2018 at 11:31 AM Thomas Petazzoni
<thomas.petazzoni@bootlin.com> wrote:
>
> Hello,
>
> On Mon, 31 Dec 2018 11:07:14 -0500, Frank Hunleth wrote:
> > This includes an upstream patch that fixes the following error:
> >
> > ```
> > /home/naourr/work/instance-1/output/build/php-amqp-1.9.3/amqp_channel.c: In function 'php_amqp_destroy_fci':
> > /home/naourr/work/instance-1/output/build/php-amqp-1.9.3/amqp_channel.c:104:37: error: lvalue required as decrement operand
> >              GC_REFCOUNT(fci->object)--;
> >                                      ^~
> > /home/naourr/work/instance-1/output/build/php-amqp-1.9.3/amqp_channel.c: In function 'php_amqp_duplicate_fci':
> > /home/naourr/work/instance-1/output/build/php-amqp-1.9.3/amqp_channel.c:115:40: error: lvalue required as increment operand
> >              GC_REFCOUNT(source->object)++;
> >                                         ^~
> > make[1]: *** [Makefile:206: amqp_channel.lo] Error 1
> > ```
>
> Don't we need a similar fix for php-zmq ?

Yes - I just sent a patch up.

Frank

      reply	other threads:[~2019-01-04  4:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-31 16:07 [Buildroot] [PATCH v2 1/1] package/php_amqp: fix build with php 7.3.0 Frank Hunleth
2018-12-31 16:15 ` Thomas Petazzoni
2018-12-31 16:31 ` Thomas Petazzoni
2019-01-04  4:55   ` Frank Hunleth [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+-urNTjvCmbPx=-TqfRwSqCVjWYQA3=2Y1tpG6uVAesnsY_SQ@mail.gmail.com' \
    --to=fhunleth@troodon-software.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.