On 20 January 2016 at 11:50, Ed Bartosh <ed.bartosh@linux.intel.com> wrote:

> sshbecontroller code and tests are broken for months. Its
> functionality(running
> builds on remote machine) can be achieved by simply running manage.py
> runbuilds
> on remote machine. There is not need to keep it in the codebase and confuse
> users from my point of view.
>

I am all in favour of this, but my preference would be to leave this until
after the image customisation work is complete.

In particular, because this patchset includes migrations, it's going to add
some complexity to merging it with the image customisation branch.

Also, it's not vital work for 2.1, yet it creates new opportunities for
other stuff to break :)

Elliot




>
> This change would also make refactoring of buildcontroller code
> [YOCTO #8806] easier.
>
> The following changes since commit
> c113ef1e40b9a5007c6b6af53226389fea706094:
>
>   toaster: tests Remove symlinks from toasteruitest folder (2016-01-20
> 12:07:44 +0200)
>
> are available in the git repository at:
>
>   git://git.yoctoproject.org/poky-contrib ed/toaster/remove-ssh-controller
>
> http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=ed/toaster/remove-ssh-controller
>
> Ed Bartosh (3):
>   toaster: raise NotImplementedError
>   toaster: don't use sshbecontroller
>   toaster: remove sshbecontroller module
>
>  bitbake/lib/toaster/bldcontrol/bbcontroller.py     |  16 +-
>  .../migrations/0002_auto_20160120_1250.py          |  19 +++
>  bitbake/lib/toaster/bldcontrol/models.py           |  10 +-
>  bitbake/lib/toaster/bldcontrol/sshbecontroller.py  | 169
> ---------------------
>  bitbake/lib/toaster/bldcontrol/tests.py            |  30 +---
>  5 files changed, 32 insertions(+), 212 deletions(-)
>  create mode 100644
> bitbake/lib/toaster/bldcontrol/migrations/0002_auto_20160120_1250.py
>  delete mode 100644 bitbake/lib/toaster/bldcontrol/sshbecontroller.py
>
> --
> Regards,
> Ed
>
> --
> _______________________________________________
> toaster mailing list
> toaster@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/toaster
>



-- 
Elliot Smith
Software Engineer
Intel Open Source Technology Centre