From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id CAA7EE00B6F; Tue, 5 Apr 2016 03:10:23 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, HTML_MESSAGE, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no * trust * [209.85.161.174 listed in list.dnswl.org] * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * 0.0 HTML_MESSAGE BODY: HTML included in message * 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily * valid * -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Received: from mail-yw0-f174.google.com (mail-yw0-f174.google.com [209.85.161.174]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id D69B3E00AE4 for ; Tue, 5 Apr 2016 03:10:17 -0700 (PDT) Received: by mail-yw0-f174.google.com with SMTP id g3so10348949ywa.3 for ; Tue, 05 Apr 2016 03:10:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=XwS+wJ20t7QO9M2ee7geG5Pmg+jEMeq2lMkqRdzOi7Q=; b=CHPNhPYLYkEvhyEbRYaWh+V3h4YH8uBsazb+KruCVuKwAqT1zBYBZRvOBrtmqeiJWw sLaFNEDwhYdCbRdSxmgvuESrS2WZYChP7Y0kQxF0hJIKVv6lKdAIsw+usGZ+kp9VtlZf A4dxRf64HTDxRyM1EA0Ctnl3oi0A3A574vXXzsLjd6nhndaGxtRA4QbCUDP2rO8rU8fx L+U/ouqb0Eaet7GZi3wTsDbEqVyO1ffVKy1a/cOVp7/K8Yge3vRV6PONlLGM8v1XcUEv 5ewCSa6zlN+gmJCLZtttoOXcWHBtxHh6KtkvwsHeLorJoLYEE6qkcgyU3nLFq1671eJ+ 06fQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=XwS+wJ20t7QO9M2ee7geG5Pmg+jEMeq2lMkqRdzOi7Q=; b=X7MubgmtqHpYrMXl5ovtXfMO5aCA+ZZhg3r4lMvDJpmxeeMSq7+1InreCxWKi91vAJ 8Xmq7Zfat1Z8R1bBAlBjNT2tGDA0jEa91Wio2KAU5HNExHORffWafHhffz5smLqkrZlu dUXD3BC1xfZtnFG6zgXN3ZNFhMTvTREFmjRXFPDth/5pqtcTMOtlWv1Ev0houD8YKzpC BLgIvHl/9dXa8OvIxf3GTzAQeS/SkUiOoCYnZv20eY3ghhXqmt3I72latCSMBgvGGmsj gtltitNQqzGLolxDhoIkkY86Xii2CcCR9MQUAkmgAP7owYm4sproCdMo+l4QItirSN0D tUHA== X-Gm-Message-State: AD7BkJKTGYIJajE2J4nti2r94cAwSDyUda6BPvb67O3vA/l8GqzU248XaX2WaDuuaPLggPISkCpZTS1dcIKug8o2 MIME-Version: 1.0 X-Received: by 10.37.94.65 with SMTP id s62mr15106633ybb.85.1459851016499; Tue, 05 Apr 2016 03:10:16 -0700 (PDT) Received: by 10.129.53.2 with HTTP; Tue, 5 Apr 2016 03:10:16 -0700 (PDT) In-Reply-To: <5702971E.6020708@intel.com> References: <5702971E.6020708@intel.com> Date: Tue, 5 Apr 2016 11:10:16 +0100 Message-ID: From: "Smith, Elliot" To: Michael Wood , Ed Bartosh Cc: toaster@yoctoproject.org Subject: Re: Removing 7844358 from toaster-next ("create Build object earlier in bitbake processing") X-BeenThere: toaster@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Web based interface for BitBake List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Apr 2016 10:10:23 -0000 Content-Type: multipart/alternative; boundary=001a11426a9443dca1052fba0d39 --001a11426a9443dca1052fba0d39 Content-Type: text/plain; charset=UTF-8 I've now removed "toaster: create Build object earlier in bitbake processing" from toaster-next (and rebased on master). I've tested cli builds and Toaster builds, and both appear to be working correctly. Note that if you're using toaster-next, you will need to remove your database and recreate it (due to changes to migrations which have now been pulled). Ed's branch (ed/toaster/project-build-dir-cancel-dldir_sstatedir) includes 3 commits which are rendered obsolete by this change (oldest first): 020919b toaster: create Build object earlier in bitbake processing fdf62ed toaster: buildinfohelper Create target list for all types of build 36315fe toasterui: detect build run start correctly on Jethro Two of these (020919b and fdf62ed) were on toaster-next, but had to be removed; one (36315fe) was on Ed's branch, to fix Jethro build start detection issues in the context of his work. Unfortunately, these can't be removed cleanly by a rebase (I tried), so Ed may have to do this to ensure nothing is broken in the process. Elliot On 4 April 2016 at 17:32, Michael Wood wrote: > Yes, let's remove "toaster: create Build object earlier in bitbake > processing" from toaster-next. If it's not going up to bitbake-devel in > it's current form and It's causing a regression there isn't any point > keeping it around in toaster-next. > > Michael > > On 04/04/16 09:24, Smith, Elliot wrote: > >> We currently have this in toaster-next, but after discussion with RP, >> we've agreed that this is probably not the right way to do this. >> >> RP suggested a couple of alternatives, which I can look into this week >> (see bug https://bugzilla.yoctoproject.org/show_bug.cgi?id=8440). >> >> For the moment, can I suggest that we remove this from toaster-next and >> force push the branch? >> >> NOTE: I'm mentioning this because it will mess up everyone's Toaster >> database, as the patch included a migration. You'll need to remove any >> existing db and start again. It will also affect Ed's branch, as he rebased >> on toaster-next with this patch in it. >> >> There is also a patch created by Michael which fixed an issue with my >> patch, which I submitted to bitbake-devel last week. This failed to apply >> because 7844358 wasn't accepted. >> >> So this patch should also be ignored for now: >> >> http://lists.openembedded.org/pipermail/bitbake-devel/2016-April/007258.html >> I have already removed it from toaster-next. >> >> Details of the commit I plan to remove are below for reference. >> >> Elliot >> >> >> commit 78443585bc92eca7140267126d53f749be3cdd6a >> Author: Elliot Smith > elliot.smith@intel.com>> >> Date: Thu Jan 28 16:21:01 2016 +0000 >> >> toaster: create Build object earlier in bitbake processing >> If a build fails because of a bitbake error occurring before the >> BuildStarted event fires, we do not generate a Build object >> for command-line builds. This means that failed command-line builds >> don't appear in Toaster at all. >> To resolve, split build creation into two steps: >> 1. Just before buildTargets() is invoked on the XMLRPC server: create >> the base Build object. Note that as soon as a Toaster-triggered >> build starts, targets are added to it; but this event is the earliest >> point when task and targets are available for command-line builds. >> (This requires a new TargetsAcquired event to be fired by the XMLRPC >> server when the buildTargets() command is called.) >> 2. BuildStarted event: add any layer information to either type of >> build >> (command-line or Toaster-triggered). >> Note that the build_name property cannot be set until BuildStarted, >> as it is not available until then, which could cause problems >> for creating Build objects earlier; however, this property is >> redundant, as it's never used anywhere in Toaster, so it has been >> removed (along with any functions which refer to it). >> [YOCTO #8440] >> Signed-off-by: Elliot Smith > elliot.smith@intel.com>> >> Signed-off-by: Michael Wood > michael.g.wood@intel.com>> >> >> >> -- >> Elliot Smith >> Software Engineer >> Intel Open Source Technology Centre >> >> >> > -- > _______________________________________________ > toaster mailing list > toaster@yoctoproject.org > https://lists.yoctoproject.org/listinfo/toaster > -- Elliot Smith Software Engineer Intel Open Source Technology Centre --001a11426a9443dca1052fba0d39 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
I've now removed=C2=A0&= quot;toaster: create Build object earlier in bitbake processing"=C2=A0from toaster-next (and rebased on master).

I'= ve tested cli builds and Toaster builds, and both appear to be working corr= ectly.

Note that if you're using toaster-next, y= ou will need to remove your database and recreate it (due to changes to mig= rations which have now been pulled).

Ed's bran= ch (ed/toaster/project-build-dir-cancel-dldir_sstatedir) includes 3 commits= which are rendered obsolete by this change (oldest first):

0= 20919b=C2=A0toaster: create Build object earlier in bitbake processing
f= df62ed toaster: buildinfohelper Create target list for all types of build
36315fe=C2=A0toasterui: detect build run start correctly on Jethro=

Two of these (020919b and fdf62ed) were on toaste= r-next, but had to be removed; one (36315fe) was on Ed's branch, to fix= Jethro build start detection issues in the context of his work.

Unf= ortunately, these can't be removed cleanly by a rebase (I tried), so Ed= may have to do this to ensure nothing is broken in the process.
=
Elliot

On 4 April 2016 at 17:32, Michael Wood <micha= el.g.wood@intel.com> wrote:
Yes, let's remove=C2=A0 "toaster: create Build object earlier in = bitbake processing" from toaster-next. If it's not going up to bit= bake-devel in it's current form and It's causing a regression there= isn't any point keeping it around in toaster-next.

Michael

On 04/04/16 09:24, Smith, Elliot wrote:
We currently have this in toaster-next, but after discussion with RP, we= 9;ve agreed that this is probably not the right way to do this.

RP suggested a couple of alternatives, which I can look into this week (see= bug https://bugzilla.yoctoproject.org/show_= bug.cgi?id=3D8440).

For the moment, can I suggest that we remove this from toaster-next and for= ce push the branch?

NOTE: I'm mentioning this because it will mess up everyone's Toaste= r database, as the patch included a migration. You'll need to remove an= y existing db and start again. It will also affect Ed's branch, as he r= ebased on toaster-next with this patch in it.

There is also a patch created by Michael which fixed an issue with my patch= , which I submitted to bitbake-devel last week. This failed to apply becaus= e 7844358 wasn't accepted.

So this patch should also be ignored for now:
http://lists.openembedde= d.org/pipermail/bitbake-devel/2016-April/007258.html
I have already removed it from toaster-next.

Details of the commit I plan to remove are below for reference.

Elliot


commit 78443585bc92eca7140267126d53f749be3cdd6a
 Author: Elliot Smith <elliot.smith@intel.com <mailto:elliot.smith@intel.com>>
Date:=C2=A0 =C2=A0Thu Jan 28 16:21:01 2016 +0000

=C2=A0 =C2=A0 toaster: create Build object earlier in bitbake processing =C2=A0 =C2=A0 If a build fails because of a bitbake error occurring before = the
=C2=A0 =C2=A0 BuildStarted event fires, we do not generate a Build object =C2=A0 =C2=A0 for command-line builds. This means that failed command-line = builds
=C2=A0 =C2=A0 don't appear in Toaster at all.
=C2=A0 =C2=A0 To resolve, split build creation into two steps:
=C2=A0 =C2=A0 1. Just before buildTargets() is invoked on the XMLRPC server= : create
=C2=A0 =C2=A0 the base Build object. Note that as soon as a Toaster-trigger= ed
=C2=A0 =C2=A0 build starts, targets are added to it; but this event is the = earliest
=C2=A0 =C2=A0 point when task and targets are available for command-line bu= ilds.
=C2=A0 =C2=A0 (This requires a new TargetsAcquired event to be fired by the= XMLRPC
=C2=A0 =C2=A0 server when the buildTargets() command is called.)
=C2=A0 =C2=A0 2. BuildStarted event: add any layer information to either ty= pe of build
=C2=A0 =C2=A0 (command-line or Toaster-triggered).
=C2=A0 =C2=A0 Note that the build_name property cannot be set until BuildSt= arted,
=C2=A0 =C2=A0 as it is not available until then, which could cause problems=
=C2=A0 =C2=A0 for creating Build objects earlier; however, this property is=
=C2=A0 =C2=A0 redundant, as it's never used anywhere in Toaster, so it = has been
=C2=A0 =C2=A0 removed (along with any functions which refer to it).
=C2=A0 =C2=A0 [YOCTO #8440]
 =C2=A0 =C2=A0 Signed-off-by: Elliot Smith <elliot.smith@intel.com <mailto:elliot.smith@intel.co= m>>
=C2=A0 =C2=A0 Signed-off-by: Michael Wood <michael.g.wood@intel.com <mailto:michael.g.wood@= intel.com>>


--
Elliot Smith
Software Engineer
Intel Open Source Technology Centre



--
_______________________________________________
toaster mailing list
toaster@yocto= project.org
https://lists.yoctoproject.org/listinfo/toaster



--
Elliot Smith
Soft= ware Engineer
Intel Open Source Technology Centre
--001a11426a9443dca1052fba0d39--