* [review-request][PATCH] toaster: write variables to toaster.conf
@ 2016-01-18 7:31 Ed Bartosh
2016-01-19 16:14 ` Smith, Elliot
0 siblings, 1 reply; 2+ messages in thread
From: Ed Bartosh @ 2016-01-18 7:31 UTC (permalink / raw)
To: toaster
With the resent change in rootfs creation code setVariable
rpc calls don't set variables for bitbake workers anymore.
Writen variables to toaster.conf should solve this issue.
[YOCTO #8910]
Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
---
bitbake/lib/toaster/bldcontrol/localhostbecontroller.py | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/bitbake/lib/toaster/bldcontrol/localhostbecontroller.py b/bitbake/lib/toaster/bldcontrol/localhostbecontroller.py
index 4f6f15c..2215d7af2 100644
--- a/bitbake/lib/toaster/bldcontrol/localhostbecontroller.py
+++ b/bitbake/lib/toaster/bldcontrol/localhostbecontroller.py
@@ -280,6 +280,13 @@ class LocalhostBEController(BuildEnvironmentController):
# set up the build environment with the needed layers
self.setLayers(bitbake, layers, targets)
+ # write configuration file
+ filepath = os.path.join(self.be.builddir, "conf/toaster.conf")
+ with open(filepath, 'w') as conf:
+ for var in variables:
+ conf.write('%s="%s"\n' % (var.name, var.value))
+ conf.write('INHERIT+="toaster buildhistory"')
+
# get the bb server running with the build req id and build env id
bbctrl = self.getBBController()
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [review-request][PATCH] toaster: write variables to toaster.conf
2016-01-18 7:31 [review-request][PATCH] toaster: write variables to toaster.conf Ed Bartosh
@ 2016-01-19 16:14 ` Smith, Elliot
0 siblings, 0 replies; 2+ messages in thread
From: Smith, Elliot @ 2016-01-19 16:14 UTC (permalink / raw)
To: Ed Bartosh; +Cc: toaster
[-- Attachment #1: Type: text/plain, Size: 1760 bytes --]
On 18 January 2016 at 07:31, Ed Bartosh <ed.bartosh@linux.intel.com> wrote:
> With the resent change in rootfs creation code setVariable
> rpc calls don't set variables for bitbake workers anymore.
>
Sent to bitbake-devel and added to toaster-next.
Elliot
>
> Writen variables to toaster.conf should solve this issue.
>
> [YOCTO #8910]
>
> Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
> ---
> bitbake/lib/toaster/bldcontrol/localhostbecontroller.py | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/bitbake/lib/toaster/bldcontrol/localhostbecontroller.py
> b/bitbake/lib/toaster/bldcontrol/localhostbecontroller.py
> index 4f6f15c..2215d7af2 100644
> --- a/bitbake/lib/toaster/bldcontrol/localhostbecontroller.py
> +++ b/bitbake/lib/toaster/bldcontrol/localhostbecontroller.py
> @@ -280,6 +280,13 @@ class
> LocalhostBEController(BuildEnvironmentController):
> # set up the build environment with the needed layers
> self.setLayers(bitbake, layers, targets)
>
> + # write configuration file
> + filepath = os.path.join(self.be.builddir, "conf/toaster.conf")
> + with open(filepath, 'w') as conf:
> + for var in variables:
> + conf.write('%s="%s"\n' % (var.name, var.value))
> + conf.write('INHERIT+="toaster buildhistory"')
> +
> # get the bb server running with the build req id and build env id
> bbctrl = self.getBBController()
>
> --
> 2.1.4
>
> --
> _______________________________________________
> toaster mailing list
> toaster@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/toaster
>
--
Elliot Smith
Software Engineer
Intel Open Source Technology Centre
[-- Attachment #2: Type: text/html, Size: 2821 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-01-19 16:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-18 7:31 [review-request][PATCH] toaster: write variables to toaster.conf Ed Bartosh
2016-01-19 16:14 ` Smith, Elliot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.