From: Joel Carlson <JoelsonCarl@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] libcorrect: add package
Date: Wed, 10 Oct 2018 11:08:35 -0600 [thread overview]
Message-ID: <CA+1k=2bzfU_1G8COh0yYqe8zjhm1Hq7KLfxKN7rQ5xGGpB45XQ@mail.gmail.com> (raw)
In-Reply-To: <20181010104650.39d03535@windsurf>
On Wed, Oct 10, 2018 at 2:46 AM Thomas Petazzoni
<thomas.petazzoni@bootlin.com> wrote:
>
> Hello,
>
> On Tue, 9 Oct 2018 17:46:49 -0600, Joel Carlson wrote:
> > Adds the libcorrect package. Libcorrect by default builds a shared
> > library, so require shared libraries. It also sets the -Wpedantic flag
> > in its Debug build, which first exists starting in gcc 4.8.
> >
> > Signed-off-by: Joel Carlson <JoelsonCarl@gmail.com>
> > ---
>
> After looking quickly at it, I decided to add a patch that uses
> -Wpedantic only if available, which allows to drop the dependency on
> the gcc version. The patch was submitted upstream.
>
> Applied with this change. Thanks!
>
> Thomas
Thank you for adding that patch/submitting it upstream. I had already
made some other changes and took the lazy route of just excluding the
older toolchains instead of trying to fix that as well.
-Joel
prev parent reply other threads:[~2018-10-10 17:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-09 23:46 [Buildroot] [PATCH 1/1] libcorrect: add package Joel Carlson
2018-10-10 8:46 ` Thomas Petazzoni
2018-10-10 17:08 ` Joel Carlson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+1k=2bzfU_1G8COh0yYqe8zjhm1Hq7KLfxKN7rQ5xGGpB45XQ@mail.gmail.com' \
--to=joelsoncarl@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.