From: Linus Torvalds <torvalds@linux-foundation.org>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: "Serge E. Hallyn" <serge@hallyn.com>,
Gergely Nagy <algernon@balabit.hu>,
david@lang.hm, Alan Cox <alan@lxorguk.ukuu.org.uk>,
Marc Koschewski <marc@osknowledge.org>,
lkml <linux-kernel@vger.kernel.org>,
James Morris <jmorris@namei.org>,
Nick Bowler <nbowler@elliptictech.com>
Subject: Re: [PATCH/RFC] cap_syslog: make CAP_SYS_ADMIN deprecation notice less alarming
Date: Fri, 5 Aug 2011 08:50:06 -1000 [thread overview]
Message-ID: <CA+55aFw0d0bGQhtLB602=_i-PAMmkBs0vRocvtRZUU33xS8=4A@mail.gmail.com> (raw)
In-Reply-To: <20110803164837.GA2669@elie>
On Wed, Aug 3, 2011 at 6:48 AM, Jonathan Nieder <jrnieder@gmail.com> wrote:
>
> Convert the WARN_ONCE to a printk_once to avoid this while continuing
> to give userspace developers a hint that this is an unwanted
> backward-compatibility feature and won't be around forever.
The problem with this one is that converting away from a warning
doesn't just get rid of all the ugliness, it gets rid of some of the
*useful* information in the warning too.
In particular, when you have a warning like "Attempting to access
syslog", you'd better tell people *who* is attempting to access
syslog, so that they can fix it or complain to the right person.
And the warning does show what process it is (in addition to
stacktrace, tainting etc that we don't want). Your printk_once()
conversion does not.
Linus
next prev parent reply other threads:[~2011-08-05 18:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-10 14:40 [PATCH 1/1] cap_syslog: don't refuse cap_sys_admin for now (v3) Serge E. Hallyn
2011-02-10 19:16 ` Linus Torvalds
2011-02-10 22:43 ` Serge E. Hallyn
2011-02-10 22:59 ` James Morris
2011-02-11 16:32 ` Serge E. Hallyn
2011-08-03 16:48 ` [PATCH/RFC] cap_syslog: make CAP_SYS_ADMIN deprecation notice less alarming Jonathan Nieder
2011-08-04 1:28 ` James Morris
2011-08-04 4:39 ` Serge E. Hallyn
2011-08-05 13:45 ` James Morris
2011-08-05 18:50 ` Linus Torvalds [this message]
2011-08-08 4:22 ` [PATCH v2] cap_syslog: don't use WARN_ONCE for CAP_SYS_ADMIN deprecation warning Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+55aFw0d0bGQhtLB602=_i-PAMmkBs0vRocvtRZUU33xS8=4A@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=algernon@balabit.hu \
--cc=david@lang.hm \
--cc=jmorris@namei.org \
--cc=jrnieder@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marc@osknowledge.org \
--cc=nbowler@elliptictech.com \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.