From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754318AbaDDTM3 (ORCPT ); Fri, 4 Apr 2014 15:12:29 -0400 Received: from mail-ve0-f170.google.com ([209.85.128.170]:43595 "EHLO mail-ve0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754042AbaDDTM1 (ORCPT ); Fri, 4 Apr 2014 15:12:27 -0400 MIME-Version: 1.0 In-Reply-To: <20140404174842.GA25736@gmail.com> References: <20140404064120.GB11877@gmail.com> <20140404080006.GB6944@gmail.com> <533EB5F1.8060002@linux.intel.com> <20140404174842.GA25736@gmail.com> Date: Fri, 4 Apr 2014 12:12:26 -0700 X-Google-Sender-Auth: RnZvRtdmi_Xze2F9VZkA41KKLSQ Message-ID: Subject: Re: [tip:x86/reboot] [PATCH] x86: Try the BIOS reboot method before the PCI reboot method From: Linus Torvalds To: Ingo Molnar Cc: "Li, Aubrey" , Peter Anvin , Linux Kernel Mailing List , Matthew Garrett , Steven Rostedt , Thomas Gleixner , "linux-tip-commits@vger.kernel.org" , Adam Williamson Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 4, 2014 at 10:48 AM, Ingo Molnar wrote: > > 'Breaks a box' is more than enough justification to revert a patch... Indeed. That's especially true when "breaks a box" was found within a day of the patch being merged. The default thinking should be: "If we found _one_ box that broke during the merge window, that probably means that there are at least ten thousand boxes that would break if the change actually hit a major distribution kernel". Yes, developer boxes are sometimes "special". But the fact is, I doubt that's the case. Not when this kind of breakage (oops, reboot doesn't work) is actually not all that unusual. The quirk entries we have for it are *not* developer boxes. Linus