From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753210AbdK0Sld (ORCPT ); Mon, 27 Nov 2017 13:41:33 -0500 Received: from mail-it0-f42.google.com ([209.85.214.42]:44402 "EHLO mail-it0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753062AbdK0Slb (ORCPT ); Mon, 27 Nov 2017 13:41:31 -0500 X-Google-Smtp-Source: AGs4zMYcE3r7hNKNWonqDc7ws66a26BPTw87Pg/tK9vJ7wSgG2EOLuQunkCmrobftUgWSswNsPxPYSkraT55V+LxcSs= MIME-Version: 1.0 In-Reply-To: <1511803118-2552-1-git-send-email-tixxdz@gmail.com> References: <1511803118-2552-1-git-send-email-tixxdz@gmail.com> From: Linus Torvalds Date: Mon, 27 Nov 2017 10:41:30 -0800 X-Google-Sender-Auth: hegGg7EvJVbyAZsYSfN7nQKnDL4 Message-ID: Subject: Re: [PATCH v5 next 0/5] Improve Module autoloading infrastructure To: Djalal Harouni Cc: Kees Cook , Andy Lutomirski , Andrew Morton , "Luis R. Rodriguez" , James Morris , Ben Hutchings , Solar Designer , Serge Hallyn , Jessica Yu , Rusty Russell , Linux Kernel Mailing List , LSM List , "kernel-hardening@lists.openwall.com" , Jonathan Corbet , Ingo Molnar , "David S. Miller" , Network Development , Peter Zijlstra Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 27, 2017 at 9:18 AM, Djalal Harouni wrote: > > The sysctl flag is available at "/proc/sys/kernel/modules_autoload_mode" > > When modules_autoload_mode is set to (0), the default, there are no > restrictions. So quick question: do we actually need this? Yes, it may be the current default, but is it anything that people actually depend on? I'd have expected that most module loading comes from system actions anyway, not normal users. So I'd like to explore first whether it even makes sense to make a new option. New options are bad because: - opt-in security isn't security at all - having to configure things is complex so we should generally strive to _not_ need new random config options. What are the real life use-cases for normal users having modules auto-load? Linus From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Torvalds Subject: Re: [PATCH v5 next 0/5] Improve Module autoloading infrastructure Date: Mon, 27 Nov 2017 10:41:30 -0800 Message-ID: References: <1511803118-2552-1-git-send-email-tixxdz@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Cc: Kees Cook , Andy Lutomirski , Andrew Morton , "Luis R. Rodriguez" , James Morris , Ben Hutchings , Solar Designer , Serge Hallyn , Jessica Yu , Rusty Russell , Linux Kernel Mailing List , LSM List , "kernel-hardening@lists.openwall.com" , Jonathan Corbet , Ingo Molnar , "David S. Miller" , Network Development , Peter Zijlstra To: Djalal Harouni Return-path: In-Reply-To: <1511803118-2552-1-git-send-email-tixxdz@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Mon, Nov 27, 2017 at 9:18 AM, Djalal Harouni wrote: > > The sysctl flag is available at "/proc/sys/kernel/modules_autoload_mode" > > When modules_autoload_mode is set to (0), the default, there are no > restrictions. So quick question: do we actually need this? Yes, it may be the current default, but is it anything that people actually depend on? I'd have expected that most module loading comes from system actions anyway, not normal users. So I'd like to explore first whether it even makes sense to make a new option. New options are bad because: - opt-in security isn't security at all - having to configure things is complex so we should generally strive to _not_ need new random config options. What are the real life use-cases for normal users having modules auto-load? Linus From mboxrd@z Thu Jan 1 00:00:00 1970 From: torvalds@linux-foundation.org (Linus Torvalds) Date: Mon, 27 Nov 2017 10:41:30 -0800 Subject: [PATCH v5 next 0/5] Improve Module autoloading infrastructure In-Reply-To: <1511803118-2552-1-git-send-email-tixxdz@gmail.com> References: <1511803118-2552-1-git-send-email-tixxdz@gmail.com> Message-ID: To: linux-security-module@vger.kernel.org List-Id: linux-security-module.vger.kernel.org On Mon, Nov 27, 2017 at 9:18 AM, Djalal Harouni wrote: > > The sysctl flag is available at "/proc/sys/kernel/modules_autoload_mode" > > When modules_autoload_mode is set to (0), the default, there are no > restrictions. So quick question: do we actually need this? Yes, it may be the current default, but is it anything that people actually depend on? I'd have expected that most module loading comes from system actions anyway, not normal users. So I'd like to explore first whether it even makes sense to make a new option. New options are bad because: - opt-in security isn't security at all - having to configure things is complex so we should generally strive to _not_ need new random config options. What are the real life use-cases for normal users having modules auto-load? Linus -- To unsubscribe from this list: send the line "unsubscribe linux-security-module" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 MIME-Version: 1.0 Sender: linus971@gmail.com In-Reply-To: <1511803118-2552-1-git-send-email-tixxdz@gmail.com> References: <1511803118-2552-1-git-send-email-tixxdz@gmail.com> From: Linus Torvalds Date: Mon, 27 Nov 2017 10:41:30 -0800 Message-ID: Content-Type: text/plain; charset="UTF-8" Subject: [kernel-hardening] Re: [PATCH v5 next 0/5] Improve Module autoloading infrastructure To: Djalal Harouni Cc: Kees Cook , Andy Lutomirski , Andrew Morton , "Luis R. Rodriguez" , James Morris , Ben Hutchings , Solar Designer , Serge Hallyn , Jessica Yu , Rusty Russell , Linux Kernel Mailing List , LSM List , "kernel-hardening@lists.openwall.com" , Jonathan Corbet , Ingo Molnar , "David S. Miller" , Network Development , Peter Zijlstra List-ID: On Mon, Nov 27, 2017 at 9:18 AM, Djalal Harouni wrote: > > The sysctl flag is available at "/proc/sys/kernel/modules_autoload_mode" > > When modules_autoload_mode is set to (0), the default, there are no > restrictions. So quick question: do we actually need this? Yes, it may be the current default, but is it anything that people actually depend on? I'd have expected that most module loading comes from system actions anyway, not normal users. So I'd like to explore first whether it even makes sense to make a new option. New options are bad because: - opt-in security isn't security at all - having to configure things is complex so we should generally strive to _not_ need new random config options. What are the real life use-cases for normal users having modules auto-load? Linus