From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Torvalds Subject: Re: [PATCH 6/6] fs: replace f_ops->get_poll_head with a static ->f_poll_head pointer Date: Fri, 29 Jun 2018 06:40:49 -0700 Message-ID: References: <20180628142059.10017-1-hch@lst.de> <20180628142059.10017-7-hch@lst.de> <20180628181727.GH30522@ZenIV.linux.org.uk> <20180628202837.GI30522@ZenIV.linux.org.uk> <20180628213027.GK30522@ZenIV.linux.org.uk> <20180629132924.GB28510@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Cc: Al Viro , linux-fsdevel , Network Development , LKP To: Christoph Hellwig Return-path: Received: from mail-io0-f193.google.com ([209.85.223.193]:34858 "EHLO mail-io0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933017AbeF2NlB (ORCPT ); Fri, 29 Jun 2018 09:41:01 -0400 In-Reply-To: <20180629132924.GB28510@lst.de> Sender: netdev-owner@vger.kernel.org List-ID: On Fri, Jun 29, 2018 at 6:29 AM Christoph Hellwig wrote: > No need for poll_table_entry, we just need a wait_queue_head. > poll_table_entry is an select.c internal (except for two nasty driver) - > neither epoll nor most in-kernel callers use it. Well, you need the poll_table for the "poll_wait()", and you would need to be able to have multiple wait-queues even though you only have one file you're waiting for. But yes, it doesn't really need to be the full complex poll_table_entry model. Linus From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============5925566680977649423==" MIME-Version: 1.0 From: Linus Torvalds To: lkp@lists.01.org Subject: Re: [PATCH 6/6] fs: replace f_ops->get_poll_head with a static ->f_poll_head pointer Date: Fri, 29 Jun 2018 06:40:49 -0700 Message-ID: In-Reply-To: <20180629132924.GB28510@lst.de> List-Id: --===============5925566680977649423== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Fri, Jun 29, 2018 at 6:29 AM Christoph Hellwig wrote: > No need for poll_table_entry, we just need a wait_queue_head. > poll_table_entry is an select.c internal (except for two nasty driver) - > neither epoll nor most in-kernel callers use it. Well, you need the poll_table for the "poll_wait()", and you would need to be able to have multiple wait-queues even though you only have one file you're waiting for. But yes, it doesn't really need to be the full complex poll_table_entry mod= el. Linus --===============5925566680977649423==--