From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754166AbdAZVy3 (ORCPT <rfc822;w@1wt.eu>);
        Thu, 26 Jan 2017 16:54:29 -0500
Received: from mail-ot0-f193.google.com ([74.125.82.193]:33774 "EHLO
        mail-ot0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753754AbdAZVy1 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 26 Jan 2017 16:54:27 -0500
MIME-Version: 1.0
In-Reply-To: <20170126215005.GU13946@wotan.suse.de>
References: <20161216114632.22559-1-mcgrof@kernel.org> <20170112150244.12700-1-mcgrof@kernel.org>
 <20170112150244.12700-4-mcgrof@kernel.org> <20170119113857.GQ28024@kroah.com>
 <20170119162751.GJ13946@wotan.suse.de> <20170126215005.GU13946@wotan.suse.de>
From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Thu, 26 Jan 2017 13:54:20 -0800
X-Google-Sender-Auth: USejd0aiW-L0ouVaY1-rtW8bgKE
Message-ID: <CA+55aFwZNZcBjjh2Mxo+_5q6y7hKoenqsUQLfaspTuOEAB=0qQ@mail.gmail.com>
Subject: Re: [PATCH v4 3/3] p54: convert to sysdata API
To: "Luis R. Rodriguez" <mcgrof@kernel.org>
Cc: Greg KH <gregkh@linuxfoundation.org>,
        Ming Lei <ming.lei@canonical.com>, Borislav Petkov <bp@alien8.de>,
        Daniel Wagner <wagi@monom.org>, Tom Gundersen <teg@jklm.no>,
        Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
        =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= <zajec5@gmail.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Vikram Mulukutla <markivx@codeaurora.org>,
        Stephen Boyd <stephen.boyd@linaro.org>,
        Mark Brown <broonie@kernel.org>, Mimi Zohar <zohar@linux.vnet.ibm.com>,
        Takashi Iwai <tiwai@suse.de>,
        Johannes Berg <johannes@sipsolutions.net>,
        Christian Lamparter <chunkeey@googlemail.com>,
        Hauke Mehrtens <hauke@hauke-m.de>,
        Josh Boyer <jwboyer@fedoraproject.org>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        David Woodhouse <dwmw2@infradead.org>, Jiri Slaby <jslaby@suse.com>,
        Andy Lutomirski <luto@amacapital.net>,
        Wu Fengguang <fengguang.wu@intel.com>,
        Richard Purdie <rpurdie@rpsys.net>,
        Jacek Anaszewski <j.anaszewski@samsung.com>, Abhay_Salunke@dell.com,
        Julia Lawall <Julia.Lawall@lip6.fr>, Gilles.Muller@lip6.fr,
        nicolas.palix@imag.fr, David Howells <dhowells@redhat.com>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        arend.vanspriel@broadcom.com, Kalle Valo <kvalo@codeaurora.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jan 26, 2017 at 1:50 PM, Luis R. Rodriguez <mcgrof@kernel.org> wrote:
>
> OK I've added a respective helper call which would map 1-1 with the
> old sync mechanism to enable a 1-1 change, this will be called
> driver_data_request_simple(), but let me know if there is a preference
> for something else.

So just looking at this patch, what's the *advantage* to the driver writer?

Apart from the actual new feature, this patch seems to actively make
the driver uglier.

I mentioned this before, but replacing "request_firmware()" with
"driver_data_request_simple()" is SIMPLY NOT AN IMPROVEMENT.

The new name is longer and _less_ descriptive.

So I'm really not seeing why you want to make these conversions that
just make code worse.

                Linus