All of lore.kernel.org
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [git pull] vfs part 2
Date: Sat, 31 Mar 2012 12:48:22 -0700	[thread overview]
Message-ID: <CA+55aFwbHtLuo4yuDnWO-UgH5p7JThhG6uppX9hvQAXic9MS2w@mail.gmail.com> (raw)
In-Reply-To: <20120331193913.GX6589@ZenIV.linux.org.uk>

On Sat, Mar 31, 2012 at 12:39 PM, Al Viro <viro@zeniv.linux.org.uk> wrote:
>
> Variants:
>        1) drop that commit, fold obvious fix into it, leave it for for-next
> once -rc1 is there; ask you to pull the branch with that sucker excluded
>        2) fold the fix into commit, ask you to pull the resulting branch
>        3) add fix to the end of existing branch, ask to pull

Let's go for (2). I'll take a new look after the pull request, but no
guarantees that I'll then pull it.

Btw, I liked the do_lookup cleanups, but nicer commit logs would have
been good. Especially the first lines. The whole

     untangling do_lookup(), part 1
     untangling do_lookup(), part 2
     untangling do_lookup(), part 3
     untangling do_lookup(), part 4
     untangling do_lookup(), part 5
     untangling do_lookup(), part 6
     untangling do_lookup(), part 7
     untangling do_lookup(), part 8
     untangling do_lookup(), part 9

in shortlogs (and gitk!) does turn me off. So since you have to redo
the series anyway, can I ask you to perhaps try to make it a bit more
descriptive?

                       Linus

  parent reply	other threads:[~2012-03-31 19:48 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-31  5:19 [git pull] vfs part 2 Al Viro
2012-03-31 18:28 ` Linus Torvalds
2012-03-31 18:28   ` Linus Torvalds
2012-03-31 18:31   ` Linus Torvalds
2012-03-31 18:57     ` Al Viro
2012-03-31 19:29       ` Linus Torvalds
2012-03-31 19:29         ` Linus Torvalds
2012-03-31 19:39         ` Al Viro
2012-03-31 19:42           ` Al Viro
2012-03-31 19:48           ` Linus Torvalds [this message]
2012-03-31 20:08             ` Al Viro
2012-03-31 21:37               ` Linus Torvalds
  -- strict thread matches above, loose matches on Subject: below --
2015-04-15 18:14 Al Viro
2015-04-23 10:16 ` Andrey Ryabinin
2015-05-25  8:30   ` Andrey Ryabinin
2015-06-21 21:12   ` Al Viro
2015-06-21 21:12     ` Al Viro
2015-06-21 21:16     ` Linus Torvalds
2015-06-21 21:16       ` Linus Torvalds
2015-06-21 21:35       ` Al Viro
2015-06-21 21:35         ` Al Viro
2015-06-22 12:02     ` Andrey Ryabinin
2015-06-22 12:02       ` Andrey Ryabinin
2015-07-01  6:27       ` Al Viro
2015-07-01  7:50         ` Andrey Ryabinin
2015-07-01  8:27           ` Al Viro
2015-07-01  8:41             ` Andrey Ryabinin
2015-07-01  8:55               ` Al Viro
2015-07-01 11:25                 ` Andrey Ryabinin
2015-07-01 18:44                   ` Al Viro
2015-07-02  3:20                     ` Al Viro
2015-07-02 12:00                       ` Jeff Layton
2015-07-02 12:07                         ` Jeff Layton
2015-07-02 16:45                           ` Al Viro
2015-07-02 17:01                             ` Jeff Layton
2015-07-02 17:56                               ` Dominique Martinet
2015-07-02 18:43                                 ` Al Viro
2015-07-02 21:00                                   ` Dominique Martinet
2015-07-02 18:59                                 ` Jeff Layton
2015-07-02 20:36                                 ` Andrey Ryabinin
2015-07-02 18:40                               ` Al Viro
2015-07-02 19:16                                 ` Linus Torvalds
2015-07-02 20:44                                   ` Al Viro
2010-03-05 16:29 Al Viro
2010-03-05 19:53 ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+55aFwbHtLuo4yuDnWO-UgH5p7JThhG6uppX9hvQAXic9MS2w@mail.gmail.com \
    --to=torvalds@linux-foundation.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.