From: Linus Torvalds <torvalds@linux-foundation.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Willy Tarreau <w@1wt.eu>,
linux-kernel@vger.kernel.org, security@kernel.org,
pmatouse@redhat.com, agk@redhat.com, jbottomley@parallels.com,
mchristi@redhat.com, msnitzer@redhat.com,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 2/3] block: fail SCSI passthrough ioctls on partition devices
Date: Thu, 5 Jan 2012 09:04:31 -0800 [thread overview]
Message-ID: <CA+55aFwi2xWsmRb+kMsqJ5cq5c8WD=iPZS9WXU=9VRVaJCu2sQ@mail.gmail.com> (raw)
In-Reply-To: <4F05D286.7030205@redhat.com>
On Thu, Jan 5, 2012 at 8:40 AM, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> Aha, so this is clear and obvious. And who knows that something else won't
> break? Such as the 32-on-64 logic that already uses ENOIOCTLCMD for
> something else?
Exactly. Which is why we can try to do this in the merge window, and
fix up the fallout.
> Foolish me who found a bug, and an exploitable one for that matter, and even
> tried to fix it. Looks like security by obscurity would have served users better.
Umm. I just sent out what I think is what we *should* be doing.
You are the one who seems to just want to add hack upon hack to
things. THAT is what I really hate. It's not only in bad taste, it
*will* come back and bite us some day.
If you think that "security" is about adding new special cases and
hacks, you're so out to lunch that it isn't even funny. It is
absolutely the *last* thing you want.
Linus
next prev parent reply other threads:[~2012-01-05 17:04 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-22 18:02 [PATCH 0/3] possible privilege escalation via SG_IO ioctl (CVE-2011-4127) Paolo Bonzini
2011-12-22 18:02 ` [PATCH 1/3] block: add and use scsi_blk_cmd_ioctl Paolo Bonzini
2011-12-22 18:02 ` [PATCH 2/3] block: fail SCSI passthrough ioctls on partition devices Paolo Bonzini
2011-12-22 18:37 ` Linus Torvalds
2011-12-22 19:11 ` Willy Tarreau
2011-12-22 19:18 ` Paolo Bonzini
2011-12-22 19:44 ` Linus Torvalds
2011-12-22 20:23 ` Paolo Bonzini
2011-12-22 20:52 ` Linus Torvalds
2011-12-22 22:08 ` Paolo Bonzini
2011-12-22 22:25 ` Linus Torvalds
2011-12-22 23:48 ` Alasdair G Kergon
2011-12-23 0:07 ` Linus Torvalds
2011-12-23 6:26 ` Willy Tarreau
2011-12-23 9:22 ` Linus Torvalds
2011-12-23 9:45 ` Willy Tarreau
2011-12-23 14:15 ` Paolo Bonzini
2011-12-23 22:46 ` Linus Torvalds
2012-01-05 13:18 ` Paolo Bonzini
2012-01-05 16:16 ` Linus Torvalds
2012-01-05 16:40 ` Paolo Bonzini
2012-01-05 17:04 ` Linus Torvalds [this message]
2012-01-05 17:26 ` Paolo Bonzini
2012-01-05 23:49 ` Linus Torvalds
2011-12-26 1:41 ` Daniel Barkalow
2011-12-23 0:17 ` H. Peter Anvin
2011-12-22 18:02 ` [PATCH 3/3] dm: do not forward ioctls from logical volumes to the underlying device Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+55aFwi2xWsmRb+kMsqJ5cq5c8WD=iPZS9WXU=9VRVaJCu2sQ@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=agk@redhat.com \
--cc=hch@lst.de \
--cc=jbottomley@parallels.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mchristi@redhat.com \
--cc=msnitzer@redhat.com \
--cc=pbonzini@redhat.com \
--cc=pmatouse@redhat.com \
--cc=security@kernel.org \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.