From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030583AbbKFAny (ORCPT ); Thu, 5 Nov 2015 19:43:54 -0500 Received: from mail-io0-f181.google.com ([209.85.223.181]:36040 "EHLO mail-io0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965307AbbKFAnw (ORCPT ); Thu, 5 Nov 2015 19:43:52 -0500 MIME-Version: 1.0 In-Reply-To: <20151105.163959.1438115257720770769.davem@davemloft.net> References: <20151105.163959.1438115257720770769.davem@davemloft.net> Date: Thu, 5 Nov 2015 16:43:52 -0800 X-Google-Sender-Auth: i1iXsLe9j3ecuXvO-_gRmu_EV7g Message-ID: Subject: Re: [GIT] Sparc From: Linus Torvalds To: David Miller Cc: Andrew Morton , sparclinux@vger.kernel.org, Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 5, 2015 at 1:39 PM, David Miller wrote: > > 5) Fix iommu-common code so it doesn't emit rediculous warnings > on some architectures, particularly ARM. Heh. So looking at that patch, I can't but help to react that this: #define IOMMU_ERROR_CODE (~(unsigned long) 0) is still pretty ridiculous. Maybe just (-1ul), or for those people who don't understand C unsigned long arithmetic and think that a negative unsigned long looks odd, (~0ul)? Not that this *matters*, but it's a bit odd to have to cast constants to perfectly regular C types. Linus From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Torvalds Date: Fri, 06 Nov 2015 00:43:52 +0000 Subject: Re: [GIT] Sparc Message-Id: List-Id: References: <20151105.163959.1438115257720770769.davem@davemloft.net> In-Reply-To: <20151105.163959.1438115257720770769.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: David Miller Cc: Andrew Morton , sparclinux@vger.kernel.org, Linux Kernel Mailing List On Thu, Nov 5, 2015 at 1:39 PM, David Miller wrote: > > 5) Fix iommu-common code so it doesn't emit rediculous warnings > on some architectures, particularly ARM. Heh. So looking at that patch, I can't but help to react that this: #define IOMMU_ERROR_CODE (~(unsigned long) 0) is still pretty ridiculous. Maybe just (-1ul), or for those people who don't understand C unsigned long arithmetic and think that a negative unsigned long looks odd, (~0ul)? Not that this *matters*, but it's a bit odd to have to cast constants to perfectly regular C types. Linus