From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751597AbaEFRBY (ORCPT ); Tue, 6 May 2014 13:01:24 -0400 Received: from mail-vc0-f181.google.com ([209.85.220.181]:35782 "EHLO mail-vc0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750821AbaEFRBW (ORCPT ); Tue, 6 May 2014 13:01:22 -0400 MIME-Version: 1.0 In-Reply-To: <20140506165233.GR18016@ZenIV.linux.org.uk> References: <20140502055127.GH18016@ZenIV.linux.org.uk> <20140502210813.GB32527@tucsk.piliscsaba.szeredi.hu> <20140502224022.GJ18016@ZenIV.linux.org.uk> <20140503042604.GM18016@ZenIV.linux.org.uk> <20140503182110.GN18016@ZenIV.linux.org.uk> <20140504062915.GQ18016@ZenIV.linux.org.uk> <20140506165233.GR18016@ZenIV.linux.org.uk> Date: Tue, 6 May 2014 10:01:21 -0700 X-Google-Sender-Auth: 5lA6GIUxZCvS26-ik3OKMYrOKLY Message-ID: Subject: Re: dcache shrink list corruption? From: Linus Torvalds To: Al Viro Cc: Miklos Szeredi , Dave Chinner , Linux Kernel Mailing List , linux-fsdevel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 6, 2014 at 9:52 AM, Al Viro wrote: > > OK... There's one more thing I would like to put there, if you are going to > be away for the week. It has sat in -next for a while, and it could stay > there, except that there's a _lot_ of followups touching stuff all over the > tree and I'd obviously prefer those to go into subsystem trees. Which > means inter-tree dependencies ;-/ Would you be OK if I included that one > into pull request? It just turns kvfree() into inline and takes it to > mm.h, next to is_vmalloc_addr(); Is there any particular reason for inlining this? I'd actually rather not, _especially_ if it means that a lot of "is_vmalloc_addr()" usage goes away and we may end up with this as a real interface. But no, I don't hate the patch. Linus