From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932823AbcCTBUd (ORCPT ); Sat, 19 Mar 2016 21:20:33 -0400 Received: from mail-io0-f195.google.com ([209.85.223.195]:33153 "EHLO mail-io0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932597AbcCTBUZ (ORCPT ); Sat, 19 Mar 2016 21:20:25 -0400 MIME-Version: 1.0 In-Reply-To: <20160314171737.GK17923@kvack.org> References: <20160115202131.GH6330@kvack.org> <20160120195957.GV6033@dastard> <20160120204449.GC12249@kvack.org> <20160120214546.GX6033@dastard> <20160123043922.GF6033@dastard> <20160314171737.GK17923@kvack.org> Date: Sat, 19 Mar 2016 18:20:24 -0700 X-Google-Sender-Auth: sC8cxQdIca9NPdP53LIJV0sdVw8 Message-ID: Subject: Re: aio openat Re: [PATCH 07/13] aio: enabled thread based async fsync From: Linus Torvalds To: Benjamin LaHaise Cc: Dave Chinner , Al Viro , Andrew Morton , linux-fsdevel , Linux API , Linux Kernel Mailing List , linux-aio@kvack.org, linux-mm Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 14, 2016 at 10:17 AM, Benjamin LaHaise wrote: > > I had some time last week to make an aio openat do what it can in > submit context. The results are an improvement: when openat is handled > in submit context it completes in about half the time it takes compared > to the round trip via the work queue, and it's not terribly much code > either. This looks good to me, and I do suspect that any of these aio paths should strive to have a synchronous vs threaded model. I think that makes the whole thing much more interesting from a performance standpoint. I still think the aio interface is really nasty, but this together with the table-based approach you posted earlier does make me a _lot_ happier about the implementation.It just looks way less hacky, and now it ends up exposing a rather more clever implementation too. Linus From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: MIME-Version: 1.0 In-Reply-To: <20160314171737.GK17923@kvack.org> References: <20160115202131.GH6330@kvack.org> <20160120195957.GV6033@dastard> <20160120204449.GC12249@kvack.org> <20160120214546.GX6033@dastard> <20160123043922.GF6033@dastard> <20160314171737.GK17923@kvack.org> Date: Sat, 19 Mar 2016 18:20:24 -0700 Message-ID: Subject: Re: aio openat Re: [PATCH 07/13] aio: enabled thread based async fsync From: Linus Torvalds To: Benjamin LaHaise Cc: Dave Chinner , Al Viro , Andrew Morton , linux-fsdevel , Linux API , Linux Kernel Mailing List , linux-aio@kvack.org, linux-mm Content-Type: text/plain; charset=UTF-8 Sender: owner-linux-mm@kvack.org List-ID: On Mon, Mar 14, 2016 at 10:17 AM, Benjamin LaHaise wrote: > > I had some time last week to make an aio openat do what it can in > submit context. The results are an improvement: when openat is handled > in submit context it completes in about half the time it takes compared > to the round trip via the work queue, and it's not terribly much code > either. This looks good to me, and I do suspect that any of these aio paths should strive to have a synchronous vs threaded model. I think that makes the whole thing much more interesting from a performance standpoint. I still think the aio interface is really nasty, but this together with the table-based approach you posted earlier does make me a _lot_ happier about the implementation.It just looks way less hacky, and now it ends up exposing a rather more clever implementation too. Linus -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org