From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Torvalds Subject: Re: [GIT PULL] SCSI fixes for 4.18-rc3 Date: Tue, 10 Jul 2018 10:49:42 -0700 Message-ID: References: <1530913134.3135.2.camel@HansenPartnership.com> <1530940958.3135.4.camel@HansenPartnership.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Jann Horn Cc: James Bottomley , Andrew Morton , Linux SCSI List , Linux Kernel Mailing List List-Id: linux-scsi@vger.kernel.org On Tue, Jul 10, 2018 at 10:36 AM Jann Horn wrote: > > AFAICS it does mean that if two processes use /dev/sg* - the first one > in a way that passes sg_check_file_access(), the second one in a way > that gets blocked for whatever reason -, the pr_err_once() will fire > for the process that's working and not fire for the one that got > blocked. But if nobody should be using that interface anyway, I guess > that's not a practical concern. Right. I don't expect it to trigger at all, and the "working" program should be fixed too, because I want for us to be able to just remove that idiotic direct access thing. > Also, the device is called /dev/sg%d with %d being sdp->index. I guess I could make it at least say that, although it's not like "one of them would be ok, but /dev/sd3 is right out". Linus