From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751715Ab3C0Qdh (ORCPT ); Wed, 27 Mar 2013 12:33:37 -0400 Received: from mail-ve0-f181.google.com ([209.85.128.181]:59630 "EHLO mail-ve0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750799Ab3C0Qdg (ORCPT ); Wed, 27 Mar 2013 12:33:36 -0400 MIME-Version: 1.0 In-Reply-To: <20130327152030.GY21522@ZenIV.linux.org.uk> References: <20130310221047.GA21522@ZenIV.linux.org.uk> <20130311003530.GE21522@ZenIV.linux.org.uk> <20130311180543.GF21522@ZenIV.linux.org.uk> <20130312130614.GA32237@ZenIV.linux.org.uk> <20130312194353.GI21522@ZenIV.linux.org.uk> <20130327135127.GB1738@redhat.com> <20130327152030.GY21522@ZenIV.linux.org.uk> Date: Wed, 27 Mar 2013 09:33:35 -0700 X-Google-Sender-Auth: PvPa5GgXqIeFfPXR22K5jse-bwI Message-ID: Subject: Re: Yet another pipe related oops. From: Linus Torvalds To: Al Viro Cc: Dave Jones , Linux Kernel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 27, 2013 at 8:20 AM, Al Viro wrote: > > Actually, that's my fault - check lost in patch reordering. My apologies ;-/ > Eventually, we want that in fs/splice.c side of things (no point repeating it > for every buffer, after all), but for now this is the obvious minimal fix. Applied. Do we actually have files with NULL f_ops pointers? Should we? What could we possibly do with a file descriptor that doesn't have any fops? Also, perhaps we should do something more akin to what we do for dentry functions where we validate them on registration, and we could fix up or validate read/write pointers, with semantics something like if (!fop->write) fop->write = fop->aio_write ? do_sync_write : EINVAL_write; if (!fop->read) fop->read = fop->aio_read ? do_sync_read : EINVAL_read; kind of things? Not a big deal, perhaps. Linus