From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751834Ab1GMU5a (ORCPT ); Wed, 13 Jul 2011 16:57:30 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:33784 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751501Ab1GMU53 convert rfc822-to-8bit (ORCPT ); Wed, 13 Jul 2011 16:57:29 -0400 MIME-Version: 1.0 In-Reply-To: References: <20110414090854.GB9248@elte.hu> <20110415101712.GB28007@elte.hu> From: Linus Torvalds Date: Wed, 13 Jul 2011 13:49:06 -0700 Message-ID: Subject: Re: [PATCH] x86 intel power: Initialize MSR_IA32_ENERGY_PERF_BIAS To: Len Brown Cc: Ingo Molnar , x86@kernel.org, linux-pm@lists.linux-foundation.org, linux-kernel@vger.kernel.org, "H. Peter Anvin" , Thomas Gleixner , Alan Cox , Andrew Morton , Arjan van de Ven Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ack. Let's just do this. Ingo? Linus On Wed, Jul 13, 2011 at 1:44 PM, Len Brown wrote: > >> So how about informing users, how about making it non-silent? An informative >> printk that also mentions the power configuration tool, etc. This solves the >> concerns i mentioned. > > Something like this? > >                rdmsrl(MSR_IA32_ENERGY_PERF_BIAS, epb); >                if ((epb & 0xF) == 0) { >                        printk_once(KERN_WARN, "x86: updated energy_perf_bias" >                                " to 'normal' from 'performance'\n" >                                "You can view and update epb via utility," >                                " such as x86_energy_perf_policy(8)\n"); >                        epb = (epb & ~0xF) | ENERGY_PERF_BIAS_NORMAL; >                        wrmsrl(MSR_IA32_ENERGY_PERF_BIAS, epb); >                } > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Torvalds Subject: Re: [PATCH] x86 intel power: Initialize MSR_IA32_ENERGY_PERF_BIAS Date: Wed, 13 Jul 2011 13:49:06 -0700 Message-ID: References: <20110414090854.GB9248@elte.hu> <20110415101712.GB28007@elte.hu> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-pm-bounces@lists.linux-foundation.org Errors-To: linux-pm-bounces@lists.linux-foundation.org To: Len Brown Cc: Andrew Morton , x86@kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , "H. Peter Anvin" , Ingo Molnar , linux-pm@lists.linux-foundation.org, Alan Cox , Arjan van de Ven List-Id: linux-pm@vger.kernel.org Ack. Let's just do this. Ingo? Linus On Wed, Jul 13, 2011 at 1:44 PM, Len Brown wrote: > >> So how about informing users, how about making it non-silent? An informa= tive >> printk that also mentions the power configuration tool, etc. This solves= the >> concerns i mentioned. > > Something like this? > > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0rdmsrl(MSR_IA32_ENERGY_PERF_BIAS, epb); > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0if ((epb & 0xF) =3D=3D 0) { > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0printk_once(KERN_WARN, "x8= 6: updated energy_perf_bias" > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0" to 'norm= al' from 'performance'\n" > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0"You can v= iew and update epb via utility," > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0" such as = x86_energy_perf_policy(8)\n"); > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0epb =3D (epb & ~0xF) | ENE= RGY_PERF_BIAS_NORMAL; > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0wrmsrl(MSR_IA32_ENERGY_PER= F_BIAS, epb); > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0} > >