From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966141Ab2JZTSj (ORCPT ); Fri, 26 Oct 2012 15:18:39 -0400 Received: from mail-we0-f174.google.com ([74.125.82.174]:54482 "EHLO mail-we0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966098Ab2JZTSi (ORCPT ); Fri, 26 Oct 2012 15:18:38 -0400 MIME-Version: 1.0 In-Reply-To: <508AE1A3.6030607@redhat.com> References: <20121025121617.617683848@chello.nl> <20121025124832.840241082@chello.nl> <5089F5B5.1050206@redhat.com> <508A0A0D.4090001@redhat.com> <508A8D31.9000106@redhat.com> <20121026132601.GC9886@gmail.com> <20121026144419.7e666023@dull> <508AE1A3.6030607@redhat.com> From: Linus Torvalds Date: Fri, 26 Oct 2012 12:18:16 -0700 X-Google-Sender-Auth: dEJXAdf72ZrQxcRdRKBFuCVMT9E Message-ID: Subject: Re: [PATCH 1/3] x86/mm: only do a local TLB flush in ptep_set_access_flags() To: Rik van Riel Cc: Ingo Molnar , Andi Kleen , Michel Lespinasse , Peter Zijlstra , Andrea Arcangeli , Mel Gorman , Johannes Weiner , Thomas Gleixner , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 26, 2012 at 12:16 PM, Rik van Riel wrote: > > I can change the text of the changelog, however it looks > like do_wp_page does actually use ptep_set_access_flags > to set the write bit in the pte... > > I guess both need to be reflected in the changelog text > somehow? Yeah, and by now, after all this discussion, I suspect it should be committed with a comment too. Commit messages are good and all, but unless chasing a particular bug they introduced, we shouldn't expect people to read them for background information. Linus From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx107.postini.com [74.125.245.107]) by kanga.kvack.org (Postfix) with SMTP id 665D16B0075 for ; Fri, 26 Oct 2012 15:18:38 -0400 (EDT) Received: by mail-wi0-f169.google.com with SMTP id hq4so710257wib.2 for ; Fri, 26 Oct 2012 12:18:36 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <508AE1A3.6030607@redhat.com> References: <20121025121617.617683848@chello.nl> <20121025124832.840241082@chello.nl> <5089F5B5.1050206@redhat.com> <508A0A0D.4090001@redhat.com> <508A8D31.9000106@redhat.com> <20121026132601.GC9886@gmail.com> <20121026144419.7e666023@dull> <508AE1A3.6030607@redhat.com> From: Linus Torvalds Date: Fri, 26 Oct 2012 12:18:16 -0700 Message-ID: Subject: Re: [PATCH 1/3] x86/mm: only do a local TLB flush in ptep_set_access_flags() Content-Type: text/plain; charset=ISO-8859-1 Sender: owner-linux-mm@kvack.org List-ID: To: Rik van Riel Cc: Ingo Molnar , Andi Kleen , Michel Lespinasse , Peter Zijlstra , Andrea Arcangeli , Mel Gorman , Johannes Weiner , Thomas Gleixner , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org On Fri, Oct 26, 2012 at 12:16 PM, Rik van Riel wrote: > > I can change the text of the changelog, however it looks > like do_wp_page does actually use ptep_set_access_flags > to set the write bit in the pte... > > I guess both need to be reflected in the changelog text > somehow? Yeah, and by now, after all this discussion, I suspect it should be committed with a comment too. Commit messages are good and all, but unless chasing a particular bug they introduced, we shouldn't expect people to read them for background information. Linus -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org