From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932415AbcHKWaO (ORCPT <rfc822;w@1wt.eu>);
	Thu, 11 Aug 2016 18:30:14 -0400
Received: from mail-oi0-f65.google.com ([209.85.218.65]:33480 "EHLO
	mail-oi0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751288AbcHKWaK (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 11 Aug 2016 18:30:10 -0400
MIME-Version: 1.0
In-Reply-To: <20160811221634.GU2356@ZenIV.linux.org.uk>
References: <87a8gk17x7.fsf@yhuang-mobile.sh.intel.com> <CA+55aFyQ6cjKOQZKEuQV9ch+aerW1Q6uGdv+pCS81rX0yjyR6w@mail.gmail.com>
 <8760r816wf.fsf@yhuang-mobile.sh.intel.com> <CA+55aFy=xeEKgfHWisfxsZNqrgMJxvKvhrWrPmdpMxu0pnOXig@mail.gmail.com>
 <20160811155721.GA23015@lst.de> <CA+55aFyVqdk0p6pmEx_gOs_AiH0TJ23ZEUDZHc9kiFbqEk8UOw@mail.gmail.com>
 <874m6ryz0u.fsf@yhuang-mobile.sh.intel.com> <CA+55aFzdnCDcf8nVtMTX7XiEoZVUqFahVA7kdns5aGKBWFqn3Q@mail.gmail.com>
 <20160811200018.GA28271@lst.de> <CA+55aFwPqsxBquvAdgvEgE+stgvMi4ecw26zP7Q1Xi3N6fCRwQ@mail.gmail.com>
 <20160811221634.GU2356@ZenIV.linux.org.uk>
From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Thu, 11 Aug 2016 15:30:08 -0700
X-Google-Sender-Auth: W88FOLpColi2oa9T2chIYsp5yQk
Message-ID: <CA+55aFxd-smj5PkN96byr1ZJZ2bgymTBpRYQXq5Ph=4EwRDGpQ@mail.gmail.com>
Subject: Re: [LKP] [lkp] [xfs] 68a9f5e700: aim7.jobs-per-min -13.6% regression
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: Christoph Hellwig <hch@lst.de>, "Huang, Ying" <ying.huang@intel.com>,
        Dave Chinner <david@fromorbit.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Bob Peterson <rpeterso@redhat.com>,
        Wu Fengguang <fengguang.wu@intel.com>, LKP <lkp@01.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Aug 11, 2016 at 3:16 PM, Al Viro <viro@zeniv.linux.org.uk> wrote:
>
> Huh?  The very first thing it does is
>         char *kaddr = kmap_atomic(page), *p = kaddr + offset;
>
> If _that_ does not disable pagefaults, we are very deep in shit.

Right you are - it does, even with highmem disabled. Never mind, those
pagefault_disabled/enabled() calls are clearly bogus.

         Linus

From mboxrd@z Thu Jan  1 00:00:00 1970
Content-Type: multipart/mixed; boundary="===============4447772468204003427=="
MIME-Version: 1.0
From: Linus Torvalds <torvalds@linux-foundation.org>
To: lkp@lists.01.org
Subject: Re: [xfs] 68a9f5e700: aim7.jobs-per-min -13.6% regression
Date: Thu, 11 Aug 2016 15:30:08 -0700
Message-ID: <CA+55aFxd-smj5PkN96byr1ZJZ2bgymTBpRYQXq5Ph=4EwRDGpQ@mail.gmail.com>
In-Reply-To: <20160811221634.GU2356@ZenIV.linux.org.uk>
List-Id: <oe-lkp.lists.linux.dev>

--===============4447772468204003427==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable

On Thu, Aug 11, 2016 at 3:16 PM, Al Viro <viro@zeniv.linux.org.uk> wrote:
>
> Huh?  The very first thing it does is
>         char *kaddr =3D kmap_atomic(page), *p =3D kaddr + offset;
>
> If _that_ does not disable pagefaults, we are very deep in shit.

Right you are - it does, even with highmem disabled. Never mind, those
pagefault_disabled/enabled() calls are clearly bogus.

         Linus

--===============4447772468204003427==--