From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932216AbcJEPxL (ORCPT ); Wed, 5 Oct 2016 11:53:11 -0400 Received: from mail-oi0-f41.google.com ([209.85.218.41]:35531 "EHLO mail-oi0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754168AbcJEPxI (ORCPT ); Wed, 5 Oct 2016 11:53:08 -0400 MIME-Version: 1.0 In-Reply-To: <20161005054407.GC7297@1wt.eu> References: <20161005054407.GC7297@1wt.eu> From: Linus Torvalds Date: Wed, 5 Oct 2016 08:52:54 -0700 X-Google-Sender-Auth: DSDtEdSuh9c_F7Obj9HrzE9GpO0 Message-ID: Subject: Re: BUG_ON() in workingset_node_shadows_dec() triggers To: Willy Tarreau Cc: Paul Gortmaker , Johannes Weiner , Andrew Morton , Antonio SJ Musumeci , Miklos Szeredi , Linux Kernel Mailing List , stable Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 4, 2016 at 10:44 PM, Willy Tarreau wrote: > > I think instead we should completely remove any simple way to halt the > system and document how to do it. Having slept on it, I suspect you're right. I worry about some BUG_ON() that really relies on the killing behavior, but if it takes a "real" fault later, that is when it gets killed. And on the whole, we've had lots of problems with the killing behavior over the years, so we should just try switching BUG_ON() over to non-fatal. It's unlikely to be worse than what we have now, as exemplified by this event. Linus