From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752463AbcISTPp (ORCPT <rfc822;w@1wt.eu>);
        Mon, 19 Sep 2016 15:15:45 -0400
Received: from mail-oi0-f66.google.com ([209.85.218.66]:33553 "EHLO
        mail-oi0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752098AbcISTPn (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 19 Sep 2016 15:15:43 -0400
MIME-Version: 1.0
In-Reply-To: <CA+55aFy=doUjoJh7fKpevV-JvEYjvfV5ZdQav+yiFBwygZ-Pag@mail.gmail.com>
References: <20160915072425.GN5008@twins.programming.kicks-ass.net>
 <20160915121014.ox5ytlplt7wz5cpk@treble> <20160916144807.6yrdznupo3bpe5b2@treble>
 <CA+55aFwa4so_H-yjgzV5gU1OyCapU7=-hY5LTcMFHfgqsPuXeQ@mail.gmail.com>
 <20160916191738.v3kq3c44zmdsvlgb@treble> <CA+55aFz_=-WQMZ3exuSEzNUzdB_ica8VZtCbf3wsj1XGFOTS+w@mail.gmail.com>
 <20160916212656.bnmxrl3cglsbjmpm@treble> <CA+55aFyUL1brPvMHrGv8qQ4HzyOsE27J_X55ZSRkRZp+p_pcgg@mail.gmail.com>
 <20160917004212.tsr3taygbcidvgl5@treble> <CA+55aFxo-kcYsMg5oF_YNxGH8ydm2p+=K885k6+YWzMxHniFFg@mail.gmail.com>
 <20160919155214.ap2cgwjkjn2s7itr@treble> <CA+55aFy=doUjoJh7fKpevV-JvEYjvfV5ZdQav+yiFBwygZ-Pag@mail.gmail.com>
From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Mon, 19 Sep 2016 12:15:42 -0700
X-Google-Sender-Auth: hbWT88bGe3hAv6wgY21R0DHpdtw
Message-ID: <CA+55aFxekTpeBPA1cwTYHOSErLStH4_H7jyh0KsuH1upRvuQ7g@mail.gmail.com>
Subject: Re: [PATCH v3] scripts: add script for translating stack dump function
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
        Stephane Eranian <eranian@google.com>,
        Vince Weaver <vincent.weaver@maine.edu>,
        LKML <linux-kernel@vger.kernel.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Ingo Molnar <mingo@kernel.org>, Kees Cook <keescook@chromium.org>,
        Rabin Vincent <rabin@rab.in>, Vegard Nossum <vegard.nossum@gmail.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Sep 19, 2016 at 11:56 AM, Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>>
>> The only working (and fast) approach I could come up with was an ugly
>> hack.  It assumes that start_kernel() is in init/main.c.
>
> That sounds entirely reasonable. Maybe somebody can come up with a
> better and more general approach, but that sounds like a fine starting
> point, and any incremental improvents can happen in the tree. So I'll
> apply your patch (assuming it passes my basic testing, which I expect
> it will).

Hmm. Would you mind if I change the

        addr2line -fpie $objfile $hexaddr | sed "s;$dir_prefix;;"

into

        addr2line -fpie $objfile $hexaddr |
                sed "s; at $dir_prefix\(\./\)*; at ;"

instead? There's two changes there: matching the " at " part (to just
make the match stricter) but also matching any following "./" thing
(which shows up for our include tree files, at least for me).

With that, all the cases I threw at it looked pretty good.

But the stricter matching might not matter, of course, and maybe there
is some addr2line version that doesn't do that? So I'm checking here..

                Linus