From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Torvalds Subject: Re: [RFC/RFT PATCH 0/6] Switch GHES ioremap_page_range() to use fixmap Date: Tue, 31 Oct 2017 09:05:42 -0700 Message-ID: References: <20171031153832.17746-1-james.morse@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: Received: from mail-io0-f194.google.com ([209.85.223.194]:52087 "EHLO mail-io0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753404AbdJaQFo (ORCPT ); Tue, 31 Oct 2017 12:05:44 -0400 In-Reply-To: Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: James Morse Cc: Linux ACPI , Linux Kernel Mailing List , "linux-arm-kernel@lists.infradead.org" , the arch/x86 maintainers , Catalin Marinas , Will Deacon , Thomas Gleixner , Ingo Molnar , "H . Peter Anvin" , Borislav Petkov , "Rafael J . Wysocki" , Len Brown , Tony Luck , Tyler Baicar , Dongjiu Geng , Xie XiuQi On Tue, Oct 31, 2017 at 8:52 AM, Linus Torvalds wrote: > On Tue, Oct 31, 2017 at 8:38 AM, James Morse wrote: >> 7 files changed, 30 insertions(+), 85 deletions(-) > > Lovely. Side note: it wasn't entirely obvious what restricted the ghes driver to only x86 and arm64. I had to look up the whole HAVE_ACPI_APEI dependency. So it might be worth mentioning in the commit message why it's ok to only add the fixmap entries for those two architectures and why it's not an issue for anything else. Linus From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753634AbdJaQFq (ORCPT ); Tue, 31 Oct 2017 12:05:46 -0400 Received: from mail-io0-f194.google.com ([209.85.223.194]:52087 "EHLO mail-io0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753404AbdJaQFo (ORCPT ); Tue, 31 Oct 2017 12:05:44 -0400 X-Google-Smtp-Source: ABhQp+SJtsE+qmC+b0dfdFY+nRndCR9hu2CpvaLtldKy5FWddL4l2Z3Wo5hx0kuA/4KQMH9Fqs93fmA/C1tQw0ThNsE= MIME-Version: 1.0 In-Reply-To: References: <20171031153832.17746-1-james.morse@arm.com> From: Linus Torvalds Date: Tue, 31 Oct 2017 09:05:42 -0700 X-Google-Sender-Auth: DJV9D9zAgzn6FHwvJ97I2XtXsiQ Message-ID: Subject: Re: [RFC/RFT PATCH 0/6] Switch GHES ioremap_page_range() to use fixmap To: James Morse Cc: Linux ACPI , Linux Kernel Mailing List , "linux-arm-kernel@lists.infradead.org" , "the arch/x86 maintainers" , Catalin Marinas , Will Deacon , Thomas Gleixner , Ingo Molnar , "H . Peter Anvin" , Borislav Petkov , "Rafael J . Wysocki" , Len Brown , Tony Luck , Tyler Baicar , Dongjiu Geng , Xie XiuQi Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 31, 2017 at 8:52 AM, Linus Torvalds wrote: > On Tue, Oct 31, 2017 at 8:38 AM, James Morse wrote: >> 7 files changed, 30 insertions(+), 85 deletions(-) > > Lovely. Side note: it wasn't entirely obvious what restricted the ghes driver to only x86 and arm64. I had to look up the whole HAVE_ACPI_APEI dependency. So it might be worth mentioning in the commit message why it's ok to only add the fixmap entries for those two architectures and why it's not an issue for anything else. Linus From mboxrd@z Thu Jan 1 00:00:00 1970 From: torvalds@linux-foundation.org (Linus Torvalds) Date: Tue, 31 Oct 2017 09:05:42 -0700 Subject: [RFC/RFT PATCH 0/6] Switch GHES ioremap_page_range() to use fixmap In-Reply-To: References: <20171031153832.17746-1-james.morse@arm.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Oct 31, 2017 at 8:52 AM, Linus Torvalds wrote: > On Tue, Oct 31, 2017 at 8:38 AM, James Morse wrote: >> 7 files changed, 30 insertions(+), 85 deletions(-) > > Lovely. Side note: it wasn't entirely obvious what restricted the ghes driver to only x86 and arm64. I had to look up the whole HAVE_ACPI_APEI dependency. So it might be worth mentioning in the commit message why it's ok to only add the fixmap entries for those two architectures and why it's not an issue for anything else. Linus