From: Linus Torvalds <torvalds@linux-foundation.org>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Git Mailing List <git@vger.kernel.org>,
bug-less@gnu.org
Subject: Re: "less -F" is broken
Date: Wed, 15 Aug 2018 14:57:05 -0700 [thread overview]
Message-ID: <CA+55aFxjUsvhHwQGthGiLr537BGHkd-LECXVv8KzBTMMCo1bKQ@mail.gmail.com> (raw)
In-Reply-To: <87k1orqpxj.fsf@evledraar.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 939 bytes --]
On Wed, Aug 15, 2018 at 2:29 PM Ævar Arnfjörð Bjarmason
<avarab@gmail.com> wrote:
>
> Downloading & trying versions of it locally reveals that it's as of
> version 520, not 530. The last version before 520 is 487. Presumably
> it's covered by this item in the changelog:
>
> Don't output terminal init sequence if using -F and file fits on one
> screen[1]
Side note: that's sad, because we already use X in the default exactly
for that reason.
So apparently "less" was broken for us to fix something that we
already had long solved. The code basically tried to do "automatic X
when F is set".
And all that line_count stuff (which is what breaks) is pointless when
-X is already given.
That does give a possible fix: just stop doing the line_count thing if
no_init is set.
So "-F" would continue to be broken, but "-FX" would work.
Something like the attached patch, perhaps?
Linus
[-- Attachment #2: patch.diff --]
[-- Type: text/x-patch, Size: 523 bytes --]
main.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/main.c b/main.c
index 179bd78..961a9db 100644
--- a/main.c
+++ b/main.c
@@ -59,6 +59,7 @@ extern int missing_cap;
extern int know_dumb;
extern int pr_type;
extern int quit_if_one_screen;
+extern int no_init;
/*
@@ -274,7 +275,7 @@ main(argc, argv)
{
if (edit_stdin()) /* Edit standard input */
quit(QUIT_ERROR);
- if (quit_if_one_screen)
+ if (quit_if_one_screen && !no_init)
line_count = get_line_count();
} else
{
next prev parent reply other threads:[~2018-08-15 21:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-15 20:35 "less -F" is broken Linus Torvalds
2018-08-15 21:23 ` Stefan Beller
2018-08-15 21:29 ` Ævar Arnfjörð Bjarmason
2018-08-15 21:43 ` Linus Torvalds
2018-08-15 21:57 ` Linus Torvalds [this message]
2018-08-16 8:22 ` Ævar Arnfjörð Bjarmason
2018-08-16 16:50 ` Mark Nudelman
2018-08-16 17:10 ` Linus Torvalds
2018-08-20 15:54 ` Mark Nudelman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+55aFxjUsvhHwQGthGiLr537BGHkd-LECXVv8KzBTMMCo1bKQ@mail.gmail.com \
--to=torvalds@linux-foundation.org \
--cc=avarab@gmail.com \
--cc=bug-less@gnu.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.