From: Linus Torvalds <torvalds@linux-foundation.org>
To: Suresh Siddha <suresh.b.siddha@intel.com>
Cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
asit.k.mallick@intel.com
Subject: Re: [patch] x86, tsc: fix SMI induced variation in quick_pit_calibrate()
Date: Mon, 16 Jan 2012 21:15:54 -0800 [thread overview]
Message-ID: <CA+55aFxjzr3qugZdfsPGPw8RooTCzTr4XQubcqjvF=t+GLHE0Q@mail.gmail.com> (raw)
In-Reply-To: <1326773165.16150.35.camel@sbsiddha-desk.sc.intel.com>
On Mon, Jan 16, 2012 at 8:06 PM, Suresh Siddha
<suresh.b.siddha@intel.com> wrote:
>
> So I suspect we can either go back to 500ppm error tolerance:
>
> if ((d1+d2) >= delta >> 10)
> continue;
>
> or increase the MAX_QUICK_PIT_MS bit more.
Agreed. Either works for me. I think I'd prefer increasing
MAX_QUICK_PIT_MS, because 25ms is still a fairly short time, but the
better we can make the precision of the clock, the better off we'll be
later.
So let's just double MAX_QUICK_PIT_MS to 50, ok?
And since you've tested it, I'm perfectly happy to sign off on that
patch so you can add my signed-off-by line. And if you can write a
reasonable description for it, maybe we can get Ingo & co to apply it.
Linus
next prev parent reply other threads:[~2012-01-17 5:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-16 20:15 [patch] x86, tsc: fix SMI induced variation in quick_pit_calibrate() Suresh Siddha
2012-01-17 0:18 ` Linus Torvalds
2012-01-17 0:41 ` Suresh Siddha
2012-01-17 0:52 ` Linus Torvalds
2012-01-17 1:30 ` Linus Torvalds
2012-01-17 4:06 ` Suresh Siddha
2012-01-17 5:15 ` Linus Torvalds [this message]
2012-01-17 23:35 ` Suresh Siddha
2012-01-18 0:25 ` [tip:x86/urgent] x86, tsc: Fix " tip-bot for Linus Torvalds
2012-01-17 2:47 ` [patch] x86, tsc: fix " Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+55aFxjzr3qugZdfsPGPw8RooTCzTr4XQubcqjvF=t+GLHE0Q@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=asit.k.mallick@intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.