From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751689AbcJGVhX (ORCPT <rfc822;w@1wt.eu>);
        Fri, 7 Oct 2016 17:37:23 -0400
Received: from mail-oi0-f68.google.com ([209.85.218.68]:32935 "EHLO
        mail-oi0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750696AbcJGVhP (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 7 Oct 2016 17:37:15 -0400
MIME-Version: 1.0
In-Reply-To: <CA+55aFzXfy3X5-0V=jNEKUVntfq_2e8-ExxCTfcgSr+LhVBv+w@mail.gmail.com>
References: <alpine.LNX.2.00.1610071022440.31629@cbobk.fhfr.pm>
 <CA+55aFwCWpyteg6xuuYY_84Vzu8KTVw-Az2_NNPGsSqqm-RA3g@mail.gmail.com>
 <1475870688.1945.13.camel@perches.com> <CA+55aFzk18SrNcAcU-Km5kXcPHqK=PT0RhwDht3vztasM-oVmg@mail.gmail.com>
 <1475871538.1945.15.camel@perches.com> <CA+55aFyMPLmxKdYK70Omhpq3SehHqdA3L97mM5dsiw-OTnhG8Q@mail.gmail.com>
 <1475872401.1945.17.camel@perches.com> <CA+55aFzXfy3X5-0V=jNEKUVntfq_2e8-ExxCTfcgSr+LhVBv+w@mail.gmail.com>
From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Fri, 7 Oct 2016 14:37:14 -0700
X-Google-Sender-Auth: 9wmNC-dJ4m87N3BwXn4E9tEuWA0
Message-ID: <CA+55aFxnEd5HGbL9rk4XOs73Cd2Ji4HXBb-M_ZSx9bPq=mb2tg@mail.gmail.com>
Subject: Re: [GIT PULL] trivial for 4.9
To: Joe Perches <joe@perches.com>
Cc: Jiri Kosina <jikos@kernel.org>,
        Colin Ian King <colin.king@canonical.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Oct 7, 2016 at 2:06 PM, Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>
> And btw, even without an explicit KERN_<level>, you should still not
> get any interleaving. Only an _explicit_ KERN_CONT should cause
> interleaving

Btw, note the "should" there. Because we do seem to have broken that
_again_.  It worked fine at some point, but lookie here:

commit 61e99ab8e35a88b8c4d0f80d3df9ee16df471be5
Author: Joe Perches <joe@perches.com>
Date:   Mon Jul 30 14:40:21 2012 -0700

    printk: remove the now unnecessary "C" annotation for KERN_CONT

    Now that all KERN_<LEVEL> uses are prefixed with ASCII SOH, there is no
    need for a KERN_CONT.  Keep it backward compatible by adding #define
    KERN_CONT ""

Joe, you *are* the problem here.

So you are literally the person who broke this.

Goddammit, I don't want to hear another peep from you. You broke this
because you wanted to save a few bytes in those strings, and then
*because* you broke it, you then argue for putting those bytes back in
the form of "\n" characters.

Fuck me sideways. You make this big deal about how this interleaving
is a big problem, and at no point did you actually point to the real
issue, which was your very own breakage where you made it all fragile.

Christ.

                    Linus