From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752941AbeAJVRs (ORCPT + 1 other); Wed, 10 Jan 2018 16:17:48 -0500 Received: from mail-it0-f45.google.com ([209.85.214.45]:41078 "EHLO mail-it0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751214AbeAJVRq (ORCPT ); Wed, 10 Jan 2018 16:17:46 -0500 X-Google-Smtp-Source: ACJfBov30dYCmqTrGa/dbSMKZCq8GIMSubX5Lv0+BpXyh2okdBKuzYSpvlvFg245RFMj3nYvh4HZu7+OWXi2osjtZn4= MIME-Version: 1.0 In-Reply-To: References: <20180110003139.10531-1-andi@firstfloor.org> <1515568506.22302.72.camel@infradead.org> <1515578735.22302.91.camel@infradead.org> <20180110112815.mgciyf5acwacphkq@pd.tnic> <20180110201532.5jnji6ypfl6slzvb@treble> <20180110205544.k2e534nkk27lkpjc@pd.tnic> <1515618537.22302.253.camel@infradead.org> From: Linus Torvalds Date: Wed, 10 Jan 2018 13:17:45 -0800 X-Google-Sender-Auth: lPyzBXBRAIyz5NQg41eSn26fB_o Message-ID: Subject: Re: [PATCH] x86/alternatives: Fix optimize_nops() checking To: David Woodhouse Cc: Borislav Petkov , Josh Poimboeuf , Thomas Gleixner , Andi Kleen , "the arch/x86 maintainers" , Linux Kernel Mailing List , Paul Turner , Andrew Lutomirski , Peter Zijlstra , Tom Lendacky , Tim Chen , Greg Kroah-Hartman , Dave Hansen , Jiri Kosina , Andi Kleen Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Wed, Jan 10, 2018 at 1:11 PM, Linus Torvalds wrote: > > Wouldn't it be much better to simply do it as part of relocation instead? .. except we only do real relocation for modules, and depend on the linker doing everything for us (handle_relocations() at load-time) I think. So it's somewhat more involved surgery. Which explains the hack. Nasty. Linus