From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752662AbdCPTay (ORCPT <rfc822;w@1wt.eu>);
        Thu, 16 Mar 2017 15:30:54 -0400
Received: from mail-it0-f50.google.com ([209.85.214.50]:35492 "EHLO
        mail-it0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751483AbdCPTaw (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 16 Mar 2017 15:30:52 -0400
MIME-Version: 1.0
In-Reply-To: <20170316152431.05316146@gandalf.local.home>
References: <20170316172008.086705006@goodmis.org> <20170316172056.576095199@goodmis.org>
 <CA+55aFwmLXLMdvM_Bur9_j6LcaHwHvng-kXEw+rUBgYKbS_6ZA@mail.gmail.com>
 <20170316140913.653af64d@gandalf.local.home> <CA+55aFwuqLGXKX=CkK6Ywoh-JNXdXtqdJhonqubRQQSEroc=dA@mail.gmail.com>
 <20170316151932.5b9167b5@gandalf.local.home> <20170316152431.05316146@gandalf.local.home>
From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Thu, 16 Mar 2017 12:30:25 -0700
X-Google-Sender-Auth: Zhe5E0_Mkfjn_7EVDvyEeFAcmOU
Message-ID: <CA+55aFxzey_vk+aFpS3L9CUr47r1W5TOUwHX15MJnKfREN20=A@mail.gmail.com>
Subject: Re: [PATCH 4/5 v3] ftrace/x86_32: Clean up ftrace_regs_caller
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Ingo Molnar <mingo@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Peter Zijlstra <peterz@infradead.org>,
        Masami Hiramatsu <mhiramat@kernel.org>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Andy Lutomirski <luto@amacapital.net>,
        Josh Poimboeuf <jpoimboe@redhat.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Mar 16, 2017 at 12:24 PM, Steven Rostedt <rostedt@goodmis.org> wrote:
>         popl    %ds
>         popl    %es
>         popl    %fs
>         popl    %gs

Do you even need these? Can they be changed by ftrace?

And see the previous email about not touching the original location at
all, adn just duplicating that entry, avoiding all the need for
shuffling. I *really* hope that ftrace doesn't depend on changing the
return %eip on the stack. That would be truly nasty.

                Linus