From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756883AbcJGUZ2 (ORCPT ); Fri, 7 Oct 2016 16:25:28 -0400 Received: from mail-oi0-f66.google.com ([209.85.218.66]:35521 "EHLO mail-oi0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753254AbcJGUZT (ORCPT ); Fri, 7 Oct 2016 16:25:19 -0400 MIME-Version: 1.0 In-Reply-To: <1475871538.1945.15.camel@perches.com> References: <1475870688.1945.13.camel@perches.com> <1475871538.1945.15.camel@perches.com> From: Linus Torvalds Date: Fri, 7 Oct 2016 13:25:18 -0700 X-Google-Sender-Auth: 1bpfL--GQijzX4X-xaYLeCsrpxw Message-ID: Subject: Re: [GIT PULL] trivial for 4.9 To: Joe Perches Cc: Jiri Kosina , Colin Ian King , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 7, 2016 at 1:18 PM, Joe Perches wrote: > > No, because any of those can be followed by a bare printk > or a pr_cont that continues the original line. .. and quite frankly, if they do, we should fix *that*. >> So really. It's a step backwards. We shouldn't need them. We should >> *remove* '\n' at the end, and then if that actually causes problems, >> we should fix those problems. > > $ git grep -w printk * | grep -v "^tools" | grep -v KERN | wc -l > 13176 > > Have at it but here are _far_ fewer missing newlines > and it'd be much lower churn to fix those than remove > all the newlines and fix the missing continuations. None of that has any relevance to the question "why should we add extra commits to go backwards"? Those newlines aren't "missing". The lack of newlines is how modern code can and does work. It's that simple. And no, I'm not interested in some mass conversion the other way _either_. I find this noise to add '\n' characters completely pointless. It's bogus stupid churn that doesn't actually make the source code better, and it also doesn't actually seem to fix any behavioral issues. And if there are behavioral issues, they should (a) be pointed out and (b) be fixed. In *no* case does it make sense to randomly just add newline characters without even having a reason for it. End of story. Linus