From: Linus Torvalds <torvalds@linux-foundation.org>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Mikko Vinni <mmvinni@yahoo.com>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Allen Kay <allen.m.kay@intel.com>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Subject: Re: [PATCH] PCI: Fix regression in pci_restore_state()
Date: Sun, 15 Apr 2012 11:59:19 -0700 [thread overview]
Message-ID: <CA+55aFyShMvUjkyGv4DgSGByuoU18o8=MnGJqbz5aSwDVyOyOA@mail.gmail.com> (raw)
In-Reply-To: <201204152047.51019.rjw@sisk.pl>
On Sun, Apr 15, 2012 at 11:47 AM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
>
> mdelay(10) doesn't really look good either to me in this case, though.
Oh, I agree. What kind of ass-backwards device actually needs that
kind of crazy delays? It is almost certainly buggy.
With retries, 10ms delays are totally unacceptable. There's something wrong.
A single ms *may* be ok.
Anyway, can you also split the actual "write _one_ register with
retry" into a function of its own? The code looks like crap with those
multiple levels of looping, with conditionals inside them etc. With a
simple helper function, you could change the break into return, and it
would look much better, I bet.
Linus
next prev parent reply other threads:[~2012-04-15 18:59 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-13 9:52 "i8042: Can't reactivate AUX port" after s2ram on 3.4-rc2 Mikko Vinni
2012-04-13 9:52 ` Mikko Vinni
2012-04-13 19:18 ` [linux-pm] " Rafael J. Wysocki
2012-04-13 19:49 ` Mikko Vinni
2012-04-13 19:49 ` Mikko Vinni
2012-04-13 20:19 ` Rafael J. Wysocki
2012-04-13 20:47 ` Mikko Vinni
2012-04-14 22:11 ` Rafael J. Wysocki
2012-04-15 10:39 ` Mikko Vinni
2012-04-15 10:39 ` Mikko Vinni
2012-04-15 18:30 ` Rafael J. Wysocki
2012-04-15 19:52 ` Rafael J. Wysocki
2012-04-15 20:56 ` Rafael J. Wysocki
2012-04-16 7:23 ` Mikko Vinni
2012-04-16 16:17 ` Rafael J. Wysocki
2012-04-16 18:57 ` Mikko Vinni
2012-04-16 19:59 ` Rafael J. Wysocki
2012-04-16 20:35 ` [PATCH] PCI: Retry BARs restoration for Type 0 headers only Rafael J. Wysocki
2012-04-16 20:35 ` Linus Torvalds
2012-04-16 21:07 ` Rafael J. Wysocki
2012-04-16 5:15 ` [linux-pm] "i8042: Can't reactivate AUX port" after s2ram on 3.4-rc2 Mikko Vinni
2012-04-16 16:14 ` Rafael J. Wysocki
2012-04-15 18:32 ` [PATCH] PCI: Fix regression in pci_restore_state() Rafael J. Wysocki
2012-04-15 18:36 ` Linus Torvalds
2012-04-15 18:47 ` Rafael J. Wysocki
2012-04-15 18:59 ` Linus Torvalds [this message]
2012-04-15 19:40 ` Rafael J. Wysocki
2012-04-23 17:03 ` Bjorn Helgaas
2012-04-23 19:53 ` Rafael J. Wysocki
2012-04-23 20:07 ` Don Dutile
2012-04-23 22:33 ` Bjorn Helgaas
2012-04-23 22:33 ` Bjorn Helgaas
2012-04-24 16:03 ` Don Dutile
2012-04-24 17:01 ` Bjorn Helgaas
2012-04-24 17:35 ` Don Dutile
2012-04-27 22:20 ` Bjorn Helgaas
2012-04-15 8:12 ` [linux-pm] "i8042: Can't reactivate AUX port" after s2ram on 3.4-rc2 James Courtier-Dutton
2012-04-15 8:12 ` James Courtier-Dutton
2012-04-15 10:47 ` Mikko Vinni
2012-04-15 10:47 ` Mikko Vinni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+55aFyShMvUjkyGv4DgSGByuoU18o8=MnGJqbz5aSwDVyOyOA@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=allen.m.kay@intel.com \
--cc=bhelgaas@google.com \
--cc=dmitry.torokhov@gmail.com \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mmvinni@yahoo.com \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.