All of lore.kernel.org
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Abelardo Ricart III <aricart@memnix.com>
Cc: Michal Marek <mmarek@suse.cz>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Sedat Dilek <sedat.dilek@gmail.com>,
	David Howells <dhowells@redhat.com>,
	keyrings@linux-nfs.org, Rusty Russell <rusty@rustcorp.com.au>,
	LSM List <linux-security-module@vger.kernel.org>,
	James Morris <james.l.morris@oracle.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] MODSIGN: Change default key details [ver #2]
Date: Sun, 3 May 2015 18:45:36 -0700	[thread overview]
Message-ID: <CA+55aFyTHjPdSgQv2iZuW7VG1bCTGMGwqcNwa1sjm9V6RkXFNw@mail.gmail.com> (raw)
In-Reply-To: <1430559977.5803.12.camel@memnix.com>

On Sat, May 2, 2015 at 2:46 AM, Abelardo Ricart III <aricart@memnix.com> wrote:
>  endif
>
> -signing_key.priv signing_key.x509: x509.genkey
> +signing_key.priv signing_key.x509: | x509.genkey

Hmm. Thinking some more about this, I'm not entirely convinced.

With this change, if we change kernel/Makefile to have a different
keysigning authority etc, it won't re-generate the keys, because the
old keys still exist. No? That would be wrong.

I'd much rather see "x509.genkey" be generated with a move-if-changed
pattern, so that it only changes if (a) it didn't exist before or (b)
it actually has new content.

On a tangentially related issue: I figured out why I get those (very
annoying) "X.509 certificate list changed" messages. I made it print
out *what* changed:

    X.509 certificate list changed from ./signing_key.x509 to signing_key.x509

Note the "./" difference.

                    Linus

  reply	other threads:[~2015-05-04  1:45 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-30 13:58 [PATCH] MODSIGN: Change default key details [ver #2] David Howells
2015-04-30 14:39 ` Sedat Dilek
2015-04-30 14:50 ` David Howells
2015-04-30 17:49   ` Sedat Dilek
2015-04-30 18:00     ` Linus Torvalds
2015-05-01 21:41       ` Abelardo Ricart III
2015-05-02  4:12         ` Linus Torvalds
2015-05-02  6:57           ` Sedat Dilek
2015-05-02  9:46           ` Abelardo Ricart III
2015-05-04  1:45             ` Linus Torvalds [this message]
2015-05-04  4:42               ` Abelardo Ricart III
     [not found]                 ` <CA+55aFzYUsXHC=_RiQFBhMmDxrFT4bqNP5F0LGWUu7Hc9sXBFQ@mail.gmail.com>
2015-05-04  7:18                   ` Abelardo Ricart III
2015-05-04 21:40                   ` Abelardo Ricart III
2015-05-05 14:34                   ` David Howells
2015-05-05 22:44                     ` Abelardo Ricart III
2015-05-04 18:45               ` Linus Torvalds
2015-05-05 15:22                 ` Michal Marek
2015-05-05 15:41                   ` Linus Torvalds
2015-05-06 12:20                     ` Michal Marek
2015-05-07 11:00                     ` David Howells
2015-05-07 12:15                       ` Michal Marek
2015-05-07 12:24                         ` Michal Marek
2015-05-08 13:05                         ` David Howells
2015-05-12  8:51                           ` Michal Marek
2015-05-15 15:21                           ` David Howells
2015-05-19 14:14                           ` David Howells
2015-05-19 15:19                             ` David Woodhouse
2015-05-18 16:07                         ` David Woodhouse
2015-05-16 15:39                 ` David Woodhouse
2015-05-18 10:47                 ` David Howells
2015-05-18 11:13                   ` David Woodhouse
2015-05-19  2:14                     ` Mimi Zohar
2015-05-18 10:56                 ` David Howells
2015-05-05 14:33               ` David Howells
2015-05-05 14:43                 ` Linus Torvalds
2015-05-05 15:30                 ` David Howells
2015-05-05 14:37               ` David Howells
2015-05-20 10:17         ` David Woodhouse
2015-05-20 11:26           ` [PATCH] modsign: Use single PEM file for autogenerated key David Woodhouse
2015-05-20 14:56           ` David Howells
2015-05-20 15:18             ` David Woodhouse
2015-05-21 11:31             ` David Woodhouse
2015-05-20 10:51         ` [PATCH] MODSIGN: Change default key details [ver #2] David Howells
2015-05-20 11:08           ` David Woodhouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+55aFyTHjPdSgQv2iZuW7VG1bCTGMGwqcNwa1sjm9V6RkXFNw@mail.gmail.com \
    --to=torvalds@linux-foundation.org \
    --cc=aricart@memnix.com \
    --cc=dhowells@redhat.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=james.l.morris@oracle.com \
    --cc=keyrings@linux-nfs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=mmarek@suse.cz \
    --cc=rusty@rustcorp.com.au \
    --cc=sedat.dilek@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.