From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752650AbcHLDU4 (ORCPT ); Thu, 11 Aug 2016 23:20:56 -0400 Received: from mail-oi0-f67.google.com ([209.85.218.67]:35564 "EHLO mail-oi0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751404AbcHLDUz (ORCPT ); Thu, 11 Aug 2016 23:20:55 -0400 MIME-Version: 1.0 In-Reply-To: <20160812025218.GB975@lst.de> References: <87eg5w18iu.fsf@yhuang-mobile.sh.intel.com> <87a8gk17x7.fsf@yhuang-mobile.sh.intel.com> <8760r816wf.fsf@yhuang-mobile.sh.intel.com> <20160811155721.GA23015@lst.de> <20160812005442.GN19025@dastard> <20160812022329.GP19025@dastard> <20160812025218.GB975@lst.de> From: Linus Torvalds Date: Thu, 11 Aug 2016 20:20:53 -0700 X-Google-Sender-Auth: WOL5uP1Ttvxp3fQ1RPIhoPHMj4U Message-ID: Subject: Re: [LKP] [lkp] [xfs] 68a9f5e700: aim7.jobs-per-min -13.6% regression To: Christoph Hellwig Cc: Dave Chinner , "Huang, Ying" , LKML , Bob Peterson , Wu Fengguang , LKP Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 11, 2016 at 7:52 PM, Christoph Hellwig wrote: > > I can look at that, but indeed optimizing this patch seems a bit > stupid. The "write less than a full block to the end of the file" is actually a reasonably common case. It may not make for a great filesystem benchmark, but it also isn't actually insane. People who do logging in user space do this all the time, for example. And it is *not* stupid in that context. Not at all. It's never going to be the *main* thing you do (unless you're AIM), but I do think it's worth fixing. And AIM7 remains one of those odd benchmarks that people use. I'm not quite sure why, but I really do think that the normal "append smaller chunks to the end of the file" should absolutely not be dismissed as stupid. Linus From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============3714556365308389214==" MIME-Version: 1.0 From: Linus Torvalds To: lkp@lists.01.org Subject: Re: [xfs] 68a9f5e700: aim7.jobs-per-min -13.6% regression Date: Thu, 11 Aug 2016 20:20:53 -0700 Message-ID: In-Reply-To: <20160812025218.GB975@lst.de> List-Id: --===============3714556365308389214== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Thu, Aug 11, 2016 at 7:52 PM, Christoph Hellwig wrote: > > I can look at that, but indeed optimizing this patch seems a bit > stupid. The "write less than a full block to the end of the file" is actually a reasonably common case. It may not make for a great filesystem benchmark, but it also isn't actually insane. People who do logging in user space do this all the time, for example. And it is *not* stupid in that context. Not at all. It's never going to be the *main* thing you do (unless you're AIM), but I do think it's worth fixing. And AIM7 remains one of those odd benchmarks that people use. I'm not quite sure why, but I really do think that the normal "append smaller chunks to the end of the file" should absolutely not be dismissed as stupid. Linus --===============3714556365308389214==--