From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932602AbcISVCV (ORCPT ); Mon, 19 Sep 2016 17:02:21 -0400 Received: from mail-oi0-f65.google.com ([209.85.218.65]:34448 "EHLO mail-oi0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751222AbcISVCT (ORCPT ); Mon, 19 Sep 2016 17:02:19 -0400 MIME-Version: 1.0 In-Reply-To: <20160919205640.fu7gjng2zkpmansu@treble> References: <20160916212656.bnmxrl3cglsbjmpm@treble> <20160917004212.tsr3taygbcidvgl5@treble> <20160919155214.ap2cgwjkjn2s7itr@treble> <20160919200055.GA17411@lnxartpec.se.axis.com> <20160919205640.fu7gjng2zkpmansu@treble> From: Linus Torvalds Date: Mon, 19 Sep 2016 14:02:18 -0700 X-Google-Sender-Auth: eYgGGGOOA3TPNJDOCXoFYWT-E-A Message-ID: Subject: Re: [PATCH v3] scripts: add script for translating stack dump function To: Josh Poimboeuf Cc: Rabin Vincent , Peter Zijlstra , Stephane Eranian , Vince Weaver , LKML , Alexander Shishkin , Ingo Molnar , Kees Cook , Vegard Nossum Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 19, 2016 at 1:56 PM, Josh Poimboeuf wrote: > On Mon, Sep 19, 2016 at 01:24:03PM -0700, Linus Torvalds wrote: >> >> because I certainly hope there is always a space there. > > No luck. The Japanese translation uses an empty string: Heh. Ok, we don't want to *just* have the "./" pattern ever be replaced, because for all I know there could be a directory name ending with "." in there somewhere. But I guess we could do it this way instead: --- a/scripts/faddr2line +++ b/scripts/faddr2line @@ -79,7 +79,7 @@ find_dir_prefix() { return fi - DIR_PREFIX=$prefix + DIR_PREFIX="$prefix\(\./\)*" return 0 } and thus just make it part of the auto-generated pattern string instead. Linus