From: Linus Torvalds <torvalds@linux-foundation.org>
To: "Rogério Brito" <rbrito@ime.usp.br>
Cc: Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
Thomas Meyer <thomas@m3y3r.de>, Gary Hade <garyhade@us.ibm.com>,
Ingo Molnar <mingo@elte.hu>,
Stefan Richter <stefanr@s5r6.in-berlin.de>,
linux-kernel@vger.kernel.org,
Jesse Barnes <jbarnes@virtuousgeek.org>,
Bjorn Helgaas <bhelgaas@google.com>,
bugme-daemon@bugzilla.kernel.org
Subject: Re: [Bug 41622] [REGRESSION][BISECTED] Notebook crashes upon detecting the PCI subsystem with kernels >= 2.6.24-rc7
Date: Wed, 24 Aug 2011 10:47:43 -0700 [thread overview]
Message-ID: <CA+55aFyyJNnL54o=xRH7CubFLDaQwcF31sqd7tfBcfR8XfnX5g@mail.gmail.com> (raw)
In-Reply-To: <CAOtrxKNVckzkxM=ahV13kV=7-Jtj=WWkx_So4pCdVX3e8mdjPw@mail.gmail.com>
2011/8/19 Rogério Brito <rbrito@ime.usp.br>:
>
> Reverting the commit above with the patch below makes me able to
> compile and run Linus's v3.1-rc2:
Oh, I just noticed that the "revert" you did actually does way more than revert.
> diff --cc drivers/pci/setup-bus.c
> index 8a1d3c7,125e7b7..0000000
> --- a/drivers/pci/setup-bus.c
> +++ b/drivers/pci/setup-bus.c
> @@@ -783,16 -486,14 +783,14 @@@ void __ref __pci_bus_size_bridges(struc
> break;
>
> case PCI_CLASS_BRIDGE_PCI:
> + /* don't size subtractive decoding (transparent)
> + * PCI-to-PCI bridges */
> + if (bus->self->transparent)
> + break;
The above is the real revert.
The below should be totally independent, and I'd like to make sure
that you test the revert without this change:
> pci_bridge_check_ranges(bus);
> - if (bus->self->is_hotplug_bridge) {
> - additional_io_size = pci_hotplug_io_size;
> - additional_mem_size = pci_hotplug_mem_size;
> - }
> - /*
> - * Follow thru
> - */
> + /* fall through */
> default:
> - pbus_size_io(bus);
> + pbus_size_io(bus, 0, additional_io_size, add_head);
And in fact I think that last line is just broken, you can't apply
that on my current -git. What's going on?
Also, I'd like to see the output of:
- cat /proc/iomem
- cat /proc/ioports
- /sbin/lspci -vvxxx
from that machine. And Bjorn asked for a full dmesg, and I see that
email, but it didn't get updated into the bugzilla entry (apparently
bugzilla is not smart enough to take email attachments and make them
bugzilla attachments). Rogério, can you do that so that it doesn't get
lost?
Linus
next prev parent reply other threads:[~2011-08-24 17:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-19 17:53 [REGRESSION][BISECTED] Notebook crashes upon detecting the PCI subsystem with kernels >= 2.6.24-rc7 Rogério Brito
2011-08-19 18:49 ` Rogério Brito
2011-08-24 17:47 ` Linus Torvalds [this message]
2011-08-24 19:30 ` [Bug 41622] " Rogério Brito
2011-08-24 20:51 ` Rogério Brito
2011-08-24 21:23 ` Bjorn Helgaas
2011-08-25 14:49 ` Rogério Brito
2011-08-25 16:53 ` Bjorn Helgaas
[not found] <bug-41622-5873@https.bugzilla.kernel.org/>
[not found] ` <20120622121523.4DF5911F873@bugzilla.kernel.org>
2012-06-22 18:20 ` Linus Torvalds
2012-06-22 19:52 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+55aFyyJNnL54o=xRH7CubFLDaQwcF31sqd7tfBcfR8XfnX5g@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=bhelgaas@google.com \
--cc=bugme-daemon@bugzilla.kernel.org \
--cc=garyhade@us.ibm.com \
--cc=ink@jurassic.park.msu.ru \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rbrito@ime.usp.br \
--cc=stefanr@s5r6.in-berlin.de \
--cc=thomas@m3y3r.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.