From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Torvalds Subject: Re: [PATCH] ACPICA: Fix possible fault in return package object repair code Date: Thu, 12 Jul 2012 10:22:44 -0700 Message-ID: References: <201207111943.19405.rjw@sisk.pl> <201207121057.31791.trenn@suse.de> <201207121100.30579.trenn@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: Received: from mail-we0-f174.google.com ([74.125.82.174]:37902 "EHLO mail-we0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161288Ab2GLRXG (ORCPT ); Thu, 12 Jul 2012 13:23:06 -0400 In-Reply-To: <201207121100.30579.trenn@suse.de> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Thomas Renninger Cc: "Rafael J. Wysocki" , Linux PM list , Len Brown , ACPI Devel Mailing List , Jonathan Nieder , Lin Ming , Bob Moore , Vlastimil Babka This needs sign-offs for the whole chain if you send it to me (ie I need to see a sign-off from the person who sends it to me) Linus On Thu, Jul 12, 2012 at 2:00 AM, Thomas Renninger wrote: > From: Bob Moore > > Fixes a problem that can occur when a lone package object is > wrapped with an outer package object in order to conform to > the ACPI specification. Can affect these predefined names: > _ALR,_MLS,_PSS,_TRT,_TSS,_PRT,_HPX,_DLM,_CSD,_PSD,_TSD > > https://bugzilla.kernel.org/show_bug.cgi?id=44171 > > The bug got introduce by commit 6a99b1c94d053b3420eaa4a4bc > in v3.4-rc6, thus it needs to get pushed into 3.4 stable > kernels as well. > > Reported-by: Vlastimil Babka > Tested-by: Vlastimil Babka > Tested-by: marc.collin@laboiteaprog.com > Signed-off-by: Bob Moore > Signed-off-by: Lin Ming > CC: stable@vger.kernel.org > > --- > drivers/acpi/acpica/nspredef.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/acpi/acpica/nspredef.c b/drivers/acpi/acpica/nspredef.c > index 23ce096..fe66260 100644 > --- a/drivers/acpi/acpica/nspredef.c > +++ b/drivers/acpi/acpica/nspredef.c > @@ -638,7 +638,7 @@ acpi_ns_check_package(struct acpi_predefined_data *data, > /* Create the new outer package and populate it */ > > status = > - acpi_ns_wrap_with_package(data, *elements, > + acpi_ns_wrap_with_package(data, return_object, > return_object_ptr); > if (ACPI_FAILURE(status)) { > return (status);