From mboxrd@z Thu Jan  1 00:00:00 1970
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753833AbeAJTij (ORCPT <rfc822;ralf@linux-mips.org> + 1 other);
        Wed, 10 Jan 2018 14:38:39 -0500
Received: from mail-it0-f47.google.com ([209.85.214.47]:39679 "EHLO
        mail-it0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753687AbeAJTih (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 10 Jan 2018 14:38:37 -0500
X-Google-Smtp-Source: ACJfBoum/SmGYCYou2ANPtMIP9sz4LYBGul6mlWJukKp2Wi9MJYDmL42NMPXSyaIHMUjRoxLgPQ4LRtwnh+3G/ieyxw=
MIME-Version: 1.0
In-Reply-To: <20180110112815.mgciyf5acwacphkq@pd.tnic>
References: <20180110003139.10531-1-andi@firstfloor.org> <CA+55aFzyVFEUKaLpqxfwh5E9QFgMjzr+wVoYGxqTHVDkGcFkOw@mail.gmail.com>
 <1515568506.22302.72.camel@infradead.org> <1515578735.22302.91.camel@infradead.org>
 <20180110112815.mgciyf5acwacphkq@pd.tnic>
From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Wed, 10 Jan 2018 11:38:36 -0800
X-Google-Sender-Auth: YHF-Q11JI1eCByQZsly-rAU-KdU
Message-ID: <CA+55aFz=yU7Q87ooyokssaFEGBx8BL+Vzs=4z+OOzvg-K5tfbA@mail.gmail.com>
Subject: Re: [PATCH] x86/alternatives: Fix optimize_nops() checking
To: Borislav Petkov <bp@alien8.de>
Cc: David Woodhouse <dwmw2@infradead.org>,
        Andi Kleen <andi@firstfloor.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        "the arch/x86 maintainers" <x86@kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Paul Turner <pjt@google.com>,
        Andrew Lutomirski <luto@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        Tim Chen <tim.c.chen@linux.intel.com>,
        Greg Kroah-Hartman <gregkh@linux-foundation.org>,
        Dave Hansen <dave.hansen@intel.com>,
        Jiri Kosina <jikos@kernel.org>, Andi Kleen <ak@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>

On Wed, Jan 10, 2018 at 3:28 AM, Borislav Petkov <bp@alien8.de> wrote:
>
> Make sure we scan all bytes before we decide to optimize the NOPs in
> there.

Can we also add compile-time checking (presumably in objtool, but who
knows) that there are no relocations in the alternative section?

Because that was the other "oops, this really doesn't work with
altinstructions" issue, wasn't it?

           Linus