All of lore.kernel.org
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Christoph Lameter <cl@linux.com>,
	Pekka Enberg <penberg@kernel.org>,
	David Rientjes <rientjes@google.com>,
	Joonsoo Kim <iamjoonsoo.kim@lge.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	"Tobin C . Harding" <me@tobin.cc>, linux-mm <linux-mm@kvack.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm/slab: Do not hash pointers when debugging slab
Date: Sun, 10 Dec 2017 12:45:10 -0800	[thread overview]
Message-ID: <CA+55aFzE0Z98KRT4rk3f3R0BcMqGMrHWHsaB9Aq02etwWm_hjg@mail.gmail.com> (raw)
In-Reply-To: <1512641861-5113-1-git-send-email-geert+renesas@glider.be>

On Thu, Dec 7, 2017 at 2:17 AM, Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
>
>         if (cachep->flags & SLAB_STORE_USER) {
> -               pr_err("Last user: [<%p>](%pSR)\n",
> +               pr_err("Last user: [<%px>](%pSR)\n",
>                        *dbg_userword(cachep, objp),
>                        *dbg_userword(cachep, objp));

Is there actually any point to the %px at all?

Why not remove it? the _real_ information is printed out by %pSR, and
that's both sufficient and useful in ways %px isn't.

> -                               pr_err("Slab corruption (%s): %s start=%p, len=%d\n",
> +                               pr_err("Slab corruption (%s): %s start=%px, len=%d\n",
>                                        print_tainted(), cachep->name,
>                                        realobj, size);

and here, is the pointer actually interesting, or should we just give
the offset to the allocation?

But if the pointer is interesting, then ack.

              Linus

WARNING: multiple messages have this Message-ID
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Christoph Lameter <cl@linux.com>,
	Pekka Enberg <penberg@kernel.org>,
	David Rientjes <rientjes@google.com>,
	Joonsoo Kim <iamjoonsoo.kim@lge.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	"Tobin C . Harding" <me@tobin.cc>, linux-mm <linux-mm@kvack.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm/slab: Do not hash pointers when debugging slab
Date: Sun, 10 Dec 2017 12:45:10 -0800	[thread overview]
Message-ID: <CA+55aFzE0Z98KRT4rk3f3R0BcMqGMrHWHsaB9Aq02etwWm_hjg@mail.gmail.com> (raw)
In-Reply-To: <1512641861-5113-1-git-send-email-geert+renesas@glider.be>

On Thu, Dec 7, 2017 at 2:17 AM, Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
>
>         if (cachep->flags & SLAB_STORE_USER) {
> -               pr_err("Last user: [<%p>](%pSR)\n",
> +               pr_err("Last user: [<%px>](%pSR)\n",
>                        *dbg_userword(cachep, objp),
>                        *dbg_userword(cachep, objp));

Is there actually any point to the %px at all?

Why not remove it? the _real_ information is printed out by %pSR, and
that's both sufficient and useful in ways %px isn't.

> -                               pr_err("Slab corruption (%s): %s start=%p, len=%d\n",
> +                               pr_err("Slab corruption (%s): %s start=%px, len=%d\n",
>                                        print_tainted(), cachep->name,
>                                        realobj, size);

and here, is the pointer actually interesting, or should we just give
the offset to the allocation?

But if the pointer is interesting, then ack.

              Linus

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2017-12-10 20:45 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-07 10:17 Geert Uytterhoeven
2017-12-07 11:13 ` Christopher Lameter
2017-12-07 11:13   ` Christopher Lameter
2017-12-07 18:43   ` Kees Cook
2017-12-07 18:43     ` Kees Cook
2017-12-07 20:15     ` Christopher Lameter
2017-12-07 20:15       ` Christopher Lameter
2017-12-10 20:45 ` Linus Torvalds [this message]
2017-12-10 20:45   ` Linus Torvalds
2017-12-11  8:08   ` Geert Uytterhoeven
2017-12-11  8:08     ` Geert Uytterhoeven
2017-12-11 12:00   ` Christopher Lameter
2017-12-11 12:00     ` Christopher Lameter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+55aFzE0Z98KRT4rk3f3R0BcMqGMrHWHsaB9Aq02etwWm_hjg@mail.gmail.com \
    --to=torvalds@linux-foundation.org \
    --cc=akpm@linux-foundation.org \
    --cc=cl@linux.com \
    --cc=geert+renesas@glider.be \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=me@tobin.cc \
    --cc=penberg@kernel.org \
    --cc=rientjes@google.com \
    --subject='Re: [PATCH] mm/slab: Do not hash pointers when debugging slab' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.