From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752483AbdLJUpP (ORCPT ); Sun, 10 Dec 2017 15:45:15 -0500 Received: from mail-it0-f54.google.com ([209.85.214.54]:40677 "EHLO mail-it0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752321AbdLJUpL (ORCPT ); Sun, 10 Dec 2017 15:45:11 -0500 X-Google-Smtp-Source: AGs4zMZ5NMiDXCI/DCCPwfs1ksyBA3kqMlb/Y7ySSaN6LohvVy7E4I+GeIhi3vm+WMeMYNvw7WU24EiojHyz+GTJYrA= MIME-Version: 1.0 In-Reply-To: <1512641861-5113-1-git-send-email-geert+renesas@glider.be> References: <1512641861-5113-1-git-send-email-geert+renesas@glider.be> From: Linus Torvalds Date: Sun, 10 Dec 2017 12:45:10 -0800 X-Google-Sender-Auth: 2yJGtEwH_sFo8A-XCNs2lwC5zLI Message-ID: Subject: Re: [PATCH] mm/slab: Do not hash pointers when debugging slab To: Geert Uytterhoeven Cc: Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , "Tobin C . Harding" , linux-mm , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 7, 2017 at 2:17 AM, Geert Uytterhoeven wrote: > > if (cachep->flags & SLAB_STORE_USER) { > - pr_err("Last user: [<%p>](%pSR)\n", > + pr_err("Last user: [<%px>](%pSR)\n", > *dbg_userword(cachep, objp), > *dbg_userword(cachep, objp)); Is there actually any point to the %px at all? Why not remove it? the _real_ information is printed out by %pSR, and that's both sufficient and useful in ways %px isn't. > - pr_err("Slab corruption (%s): %s start=%p, len=%d\n", > + pr_err("Slab corruption (%s): %s start=%px, len=%d\n", > print_tainted(), cachep->name, > realobj, size); and here, is the pointer actually interesting, or should we just give the offset to the allocation? But if the pointer is interesting, then ack. Linus From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-f69.google.com (mail-it0-f69.google.com [209.85.214.69]) by kanga.kvack.org (Postfix) with ESMTP id 13C156B0033 for ; Sun, 10 Dec 2017 15:45:16 -0500 (EST) Received: by mail-it0-f69.google.com with SMTP id w125so10962827itf.0 for ; Sun, 10 Dec 2017 12:45:16 -0800 (PST) Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id e9sor6521664ioe.155.2017.12.10.12.45.10 for (Google Transport Security); Sun, 10 Dec 2017 12:45:11 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <1512641861-5113-1-git-send-email-geert+renesas@glider.be> References: <1512641861-5113-1-git-send-email-geert+renesas@glider.be> From: Linus Torvalds Date: Sun, 10 Dec 2017 12:45:10 -0800 Message-ID: Subject: Re: [PATCH] mm/slab: Do not hash pointers when debugging slab Content-Type: text/plain; charset="UTF-8" Sender: owner-linux-mm@kvack.org List-ID: To: Geert Uytterhoeven Cc: Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , "Tobin C . Harding" , linux-mm , Linux Kernel Mailing List On Thu, Dec 7, 2017 at 2:17 AM, Geert Uytterhoeven wrote: > > if (cachep->flags & SLAB_STORE_USER) { > - pr_err("Last user: [<%p>](%pSR)\n", > + pr_err("Last user: [<%px>](%pSR)\n", > *dbg_userword(cachep, objp), > *dbg_userword(cachep, objp)); Is there actually any point to the %px at all? Why not remove it? the _real_ information is printed out by %pSR, and that's both sufficient and useful in ways %px isn't. > - pr_err("Slab corruption (%s): %s start=%p, len=%d\n", > + pr_err("Slab corruption (%s): %s start=%px, len=%d\n", > print_tainted(), cachep->name, > realobj, size); and here, is the pointer actually interesting, or should we just give the offset to the allocation? But if the pointer is interesting, then ack. Linus -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org